Issue 14868002: Do not copy immutable arrays in String.createFromCharCodes. Tighten the types a little in string_pa…

Issue 14868002: Do not copy immutable arrays in String.createFromCharCodes. Tighten the types a little in string_pa… (Closed)

Created:
7 years, 7 months ago by srdjan

Modified:
7 years, 7 months ago

Reviewers:
hausner, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Do not copy immutable arrays in String.createFromCharCodes. Tighten the types a little in string_patch.dart. R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=22338

Patch Set 2 : #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -4 lines)			Patch
	M	runtime/lib/string.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download
	M	runtime/lib/string_patch.dart	View	1	3 chunks	+7 lines, -3 lines	2 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

srdjan

Committed patchset #2 manually as r22338 (presubmit successful).

7 years, 7 months ago (2013-05-02 20:45:10 UTC) #3

Ivan Posva

DBC -ip https://codereview.chromium.org/14868002/diff/3001/runtime/lib/string_patch.dart File runtime/lib/string_patch.dart (right): https://codereview.chromium.org/14868002/diff/3001/runtime/lib/string_patch.dart#newcode31 runtime/lib/string_patch.dart:31: if (charCodes is! _ObjectArray && This will ...

7 years, 7 months ago (2013-05-03 15:44:27 UTC) #4

srdjan

7 years, 7 months ago (2013-05-03 16:44:47 UTC) #5

Message was sent while issue was closed.

https://codereview.chromium.org/14868002/diff/3001/runtime/lib/string_patch.dart
File runtime/lib/string_patch.dart (right):

https://codereview.chromium.org/14868002/diff/3001/runtime/lib/string_patch.d...
runtime/lib/string_patch.dart:31: if (charCodes is! _ObjectArray &&
On 2013/05/03 15:44:27, Ivan Posva wrote:
> This will not work long-term. Especially once we have "implements dynamic".
What
> we really need to do in the library implementations is have access to the
> classId and check for those, as the VM implementation of the libraries is an
> extension of the VM C++ code.

Good point. What is the ETA for "implements dynamic". All "is" and "as" in VM
Dart libraries need to be checked and eventually replaced with a class-id check.

I will implement a direct class check and convert VM library code to use it.

Expand Messages | Collapse Messages