Issue 14865008: Extend HttpBody handler to support 'multipart/form-data'.

Issue 14865008: Extend HttpBody handler to support 'multipart/form-data'. (Closed)

Created:
7 years, 7 months ago by Anders Johnsen

Modified:
7 years, 6 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Extend HttpBody handler to support 'multipart/form-data'. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=22457

Patch Set 2 : Fix interface. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+217 lines, -55 lines)			Patch
M	sdk/lib/io/http_body.dart	View	1	2 chunks	+24 lines, -1 line	0 comments	Download
M	sdk/lib/io/http_body_impl.dart	View		3 chunks	+107 lines, -47 lines	0 comments	Download
M	sdk/lib/io/http_multipart_form_data_impl.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	tests/standalone/io/http_body_test.dart	View		3 chunks	+83 lines, -6 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

LGTM! https://codereview.chromium.org/14865008/diff/1/sdk/lib/io/http_body.dart File sdk/lib/io/http_body.dart (right): https://codereview.chromium.org/14865008/diff/1/sdk/lib/io/http_body.dart#newcode165 sdk/lib/io/http_body.dart:165: * The data of the file. Either a ...

7 years, 7 months ago (2013-05-07 09:31:31 UTC) #2

Anders Johnsen

Committed patchset #2 manually as r22457 (presubmit successful).

7 years, 7 months ago (2013-05-07 11:57:00 UTC) #3

Anders Johnsen

7 years, 6 months ago (2013-06-11 12:23:01 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/14865008/diff/1/sdk/lib/io/http_body.dart
File sdk/lib/io/http_body.dart (right):

https://codereview.chromium.org/14865008/diff/1/sdk/lib/io/http_body.dart#new...
sdk/lib/io/http_body.dart:165: * The data of the file. Either a [String] or a
[List<int>].
On 2013/05/07 09:31:31, Søren Gjesse wrote:
> data -> content

Done.

https://codereview.chromium.org/14865008/diff/1/sdk/lib/io/http_body_impl.dart
File sdk/lib/io/http_body_impl.dart (right):

https://codereview.chromium.org/14865008/diff/1/sdk/lib/io/http_body_impl.dar...
sdk/lib/io/http_body_impl.dart:86: .fold([], (l, f) => l..add(f))
On 2013/05/07 09:31:31, Søren Gjesse wrote:
> Does this ensure that if there are more than one field with the same name that
> they will be in the same order?

Yep, it preserves the of the fields.

Expand Messages | Collapse Messages