Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Issue 14864024: Add a debugger test for closure breakpoints (Closed)

Created:
7 years, 7 months ago by hausner
Modified:
7 years, 7 months ago
Reviewers:
siva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Add a debugger test for closure breakpoints Stop at closure, step into the closure function. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=22605

Patch Set 1 #

Patch Set 2 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -1 line) Patch
A tests/standalone/debugger/closure_debugger_test.dart View 1 1 chunk +41 lines, -0 lines 2 comments Download
M tests/standalone/debugger/debug_lib.dart View 2 chunks +8 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
7 years, 7 months ago (2013-05-10 21:27:39 UTC) #1
siva
lgtm https://codereview.chromium.org/14864024/diff/2001/tests/standalone/debugger/closure_debugger_test.dart File tests/standalone/debugger/closure_debugger_test.dart (right): https://codereview.chromium.org/14864024/diff/2001/tests/standalone/debugger/closure_debugger_test.dart#newcode37 tests/standalone/debugger/closure_debugger_test.dart:37: SetBreakpoint(15), // Breakpoint in bar(); Maybe SetBreakpoint("bar") would ...
7 years, 7 months ago (2013-05-10 22:02:58 UTC) #2
hausner
Committed patchset #2 manually as r22605 (presubmit successful).
7 years, 7 months ago (2013-05-10 22:46:03 UTC) #3
hausner
7 years, 7 months ago (2013-05-16 16:32:39 UTC) #4
Message was sent while issue was closed.
Apparently forgot to send my responses.

https://codereview.chromium.org/14864024/diff/2001/tests/standalone/debugger/...
File tests/standalone/debugger/closure_debugger_test.dart (right):

https://codereview.chromium.org/14864024/diff/2001/tests/standalone/debugger/...
tests/standalone/debugger/closure_debugger_test.dart:37: SetBreakpoint(15),     
// Breakpoint in bar();
As discussed offline, this is certainly brittle code but unfortunately there is
no solution that is significantly more robust. Ideal would be if a dart program
could get access to its source file and we could put a unique comment in the
line where we want to set a breakpoint.

On 2013/05/10 22:02:58, siva wrote:
> Maybe SetBreakpoint("bar") would be more readable and less prone to errors if
> somebody decides to do a mass change of the copyright text.
> 
> Similarly 'Step, Step, Step, Step'  instead of SetBreakpoint(22) or have
another
> top level function whose first statement is the closure call.

Powered by Google App Engine
This is Rietveld 408576698