Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14863011: Deleted code that wasn't actually doing anything. (Closed)

Created:
7 years, 7 months ago by Andrei Mouravski
Modified:
7 years, 7 months ago
Reviewers:
Anton Muhin, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Changed the order of optional parameter creation so that they're created from last to first. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=22578

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -40 lines) Patch
M tools/dom/scripts/htmldartgenerator.py View 1 2 3 1 chunk +17 lines, -40 lines 2 comments Download

Messages

Total messages: 10 (0 generated)
Andrei Mouravski
Note: it does not seem like this code is called. Not sure what that's about.
7 years, 7 months ago (2013-05-07 21:43:05 UTC) #1
blois
On 2013/05/07 21:43:05, Andrei Mouravski wrote: > Note: it does not seem like this code ...
7 years, 7 months ago (2013-05-07 22:16:36 UTC) #2
Andrei Mouravski
Easy enough. :]
7 years, 7 months ago (2013-05-07 22:33:10 UTC) #3
blois
https://codereview.chromium.org/14863011/diff/5001/tools/dom/scripts/htmldartgenerator.py File tools/dom/scripts/htmldartgenerator.py (left): https://codereview.chromium.org/14863011/diff/5001/tools/dom/scripts/htmldartgenerator.py#oldcode377 tools/dom/scripts/htmldartgenerator.py:377: dispatcher_emitter = self._members_emitter.Emit( Is this being used either then?
7 years, 7 months ago (2013-05-07 23:15:06 UTC) #4
Andrei Mouravski
PTAL. https://codereview.chromium.org/14863011/diff/5001/tools/dom/scripts/htmldartgenerator.py File tools/dom/scripts/htmldartgenerator.py (left): https://codereview.chromium.org/14863011/diff/5001/tools/dom/scripts/htmldartgenerator.py#oldcode377 tools/dom/scripts/htmldartgenerator.py:377: dispatcher_emitter = self._members_emitter.Emit( On 2013/05/07 23:15:06, blois wrote: ...
7 years, 7 months ago (2013-05-08 22:52:51 UTC) #5
blois
https://codereview.chromium.org/14863011/diff/11001/tools/dom/scripts/htmldartgenerator.py File tools/dom/scripts/htmldartgenerator.py (right): https://codereview.chromium.org/14863011/diff/11001/tools/dom/scripts/htmldartgenerator.py#newcode368 tools/dom/scripts/htmldartgenerator.py:368: has_factory_provider = False Is has_factory_provider still being used?
7 years, 7 months ago (2013-05-08 22:59:05 UTC) #6
Andrei Mouravski
PTAL. https://codereview.chromium.org/14863011/diff/11001/tools/dom/scripts/htmldartgenerator.py File tools/dom/scripts/htmldartgenerator.py (right): https://codereview.chromium.org/14863011/diff/11001/tools/dom/scripts/htmldartgenerator.py#newcode368 tools/dom/scripts/htmldartgenerator.py:368: has_factory_provider = False On 2013/05/08 22:59:05, blois wrote: ...
7 years, 7 months ago (2013-05-08 23:37:34 UTC) #7
blois
lgtm
7 years, 7 months ago (2013-05-09 22:45:17 UTC) #8
Andrei Mouravski
Committed patchset #4 manually as r22578 (presubmit successful).
7 years, 7 months ago (2013-05-10 00:03:02 UTC) #9
Anton Muhin
7 years, 7 months ago (2013-05-14 15:01:40 UTC) #10
Message was sent while issue was closed. 
Sorry for stupid question, but did you regen libs after this change?

Powered by Google App Engine
This is Rietveld 408576698