Issue 148613002: Mark debugger test as failed if debug target crashes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 148613002: Mark debugger test as failed if debug target crashes (Closed)

Created:
6 years, 10 months ago by hausner

Modified:
6 years, 10 months ago

Reviewers:
zra

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Mark debugger test as failed if debug target crashes Fixes issue 13721 R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=32039

Patch Set 2 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -3 lines)			Patch
	M	tests/standalone/debugger/debug_lib.dart	View	1	1 chunk	+8 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

zra

lgtm https://codereview.chromium.org/148613002/diff/1/tests/standalone/debugger/debug_lib.dart File tests/standalone/debugger/debug_lib.dart (right): https://codereview.chromium.org/148613002/diff/1/tests/standalone/debugger/debug_lib.dart#newcode667 tests/standalone/debugger/debug_lib.dart:667: // If the process was already dead exitCode ...

6 years, 10 months ago (2014-01-27 22:44:05 UTC) #2

hausner

Committed patchset #2 manually as r32039 (presubmit successful).

6 years, 10 months ago (2014-01-27 22:59:31 UTC) #3

hausner

6 years, 10 months ago (2014-01-27 22:59:49 UTC) #4

Message was sent while issue was closed.

https://codereview.chromium.org/148613002/diff/1/tests/standalone/debugger/de...
File tests/standalone/debugger/debug_lib.dart (right):

https://codereview.chromium.org/148613002/diff/1/tests/standalone/debugger/de...
tests/standalone/debugger/debug_lib.dart:667: // If the process was already dead
exitCode is already
On 2014/01/27 22:44:05, zra wrote:
> already dead, exitCode

Done.

Expand Messages | Collapse Messages

Issue 148613002: Mark debugger test as failed if debug target crashes (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Messages