Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(80)

Issue 14858051: Handle the new analyzer type warnings in tests. (Closed)

Created:
7 years, 7 months ago by scheglov
Modified:
7 years, 7 months ago
Reviewers:
jwren, Brian Wilkerson
CC:
reviews_dartlang.org, lukeechurch_gmail.com
Visibility:
Public.

Description

Handle the new analyzer type warnings in tests. Unfortunately we are back to 600+ failing tests. R=brianwilkerson@google.com, jwren@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22876

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+81 lines, -66 lines) Patch
M tests/co19/co19-analyzer.status View 8 chunks +74 lines, -12 lines 0 comments Download
M tests/language/language.status View 15 chunks +6 lines, -53 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
scheglov
7 years, 7 months ago (2013-05-17 05:02:31 UTC) #1
Brian Wilkerson
LGTM
7 years, 7 months ago (2013-05-17 14:12:37 UTC) #2
jwren
On 2013/05/17 14:12:37, Brian Wilkerson wrote: > LGTM LGTM
7 years, 7 months ago (2013-05-17 15:08:23 UTC) #3
scheglov
7 years, 7 months ago (2013-05-17 21:55:57 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r22876 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698