Issue 14855011: Cleanup of DOM classname generation

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14855011: Cleanup of DOM classname generation (Closed)

Created:
7 years, 7 months ago by blois

Modified:
7 years, 7 months ago

Reviewers:
Emily Fortuna, sra

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

A couple changes which clean up some of the DOM class names: Changing the default name to use the JS interface name rather than interface ID- this fixes a couple of cases like DOMSecurityPolicy where the spec name is SecurityPolicy. This also picks up more names as being 'WebKit' prefixed. I made the class names automatically strip the WebKit prefix and also automatically add the experimental attribute. Like we already do for member names. BUG= R=efortuna@google.com Committed: https://code.google.com/p/dart/source/detail?r=22446

Patch Set 1 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2138 lines, -2091 lines)			Patch
M	sdk/lib/html/dart2js/html_dart2js.dart	View	29 chunks	+976 lines, -952 lines	0 comments	Download
M	sdk/lib/html/dartium/html_dartium.dart	View	30 chunks	+1155 lines, -1130 lines	0 comments	Download
M	tools/dom/scripts/dartmetadata.py	View	2 chunks	+5 lines, -1 line	0 comments	Download
M	tools/dom/scripts/htmlrenamer.py	View	4 chunks	+2 lines, -8 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

blois

7 years, 7 months ago (2013-05-06 22:58:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22446 (presubmit successful).

Expand Messages | Collapse Messages