Issue 148523006: Fix bug in internal SplayTreeIterator constructor.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 148523006: Fix bug in internal SplayTreeIterator constructor. (Closed)

Created:
6 years, 10 months ago by Lasse Reichstein Nielsen

Modified:
6 years, 10 months ago

Reviewers:
Anders Johnsen

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Fix bug in internal SplayTreeIterator constructor. Only has performance impact on the filter operations (retainWhere/removeWhere). Also remove unused empty function. R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=32056

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+49 lines, -39 lines)			Patch
	M	sdk/lib/collection/splay_tree.dart	View		2 chunks	+6 lines, -5 lines	0 comments	Download
	M	tests/corelib/splay_tree_test.dart	View	1	1 chunk	+43 lines, -34 lines	0 comments	Download

Total messages: 4 (0 generated)

Lasse Reichstein Nielsen

I didn't think it was testable, but actually it is - we just need to ...

6 years, 10 months ago (2014-01-28 08:57:11 UTC) #3

Lasse Reichstein Nielsen

6 years, 10 months ago (2014-01-28 09:16:33 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r32056 (presubmit successful).