Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 148463007: Add builder_tag option to tools/test.dart (Closed)

Created:
6 years, 10 months ago by ricow1
Modified:
6 years, 10 months ago
Reviewers:
Bob Nystrom, kasperl
CC:
reviews_dartlang.org, Bob Nystrom, Bill Hesse, Anders Johnsen
Visibility:
Public.

Description

Add builder_tag option to tools/test.dart This will allow us to pass in machine specific tags that describes the setup of a given machine. Use this to pass in the locale on the pub russian bot and to suppress the two failures we have due to issue 16356 R=kasperl@google.com Committed: https://code.google.com/p/dart/source/detail?r=32061

Patch Set 1 #

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -9 lines) Patch
M pkg/pkgbuild.status View 1 2 1 chunk +4 lines, -0 lines 0 comments Download
M tools/bots/bot.py View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M tools/bots/pub.py View 1 2 3 chunks +12 lines, -8 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 2 1 chunk +8 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
ricow1
6 years, 10 months ago (2014-01-28 09:30:34 UTC) #1
kasperl
https://codereview.chromium.org/148463007/diff/20001/tools/bots/bot.py File tools/bots/bot.py (right): https://codereview.chromium.org/148463007/diff/20001/tools/bots/bot.py#newcode43 tools/bots/bot.py:43: - test_tag: A tag indicating a specialial builder setup. ...
6 years, 10 months ago (2014-01-28 09:35:54 UTC) #2
ricow1
https://codereview.chromium.org/148463007/diff/20001/tools/bots/bot.py File tools/bots/bot.py (right): https://codereview.chromium.org/148463007/diff/20001/tools/bots/bot.py#newcode43 tools/bots/bot.py:43: - test_tag: A tag indicating a specialial builder setup. ...
6 years, 10 months ago (2014-01-28 09:49:36 UTC) #3
kasperl
LGTM if you update the CL description.
6 years, 10 months ago (2014-01-28 09:51:29 UTC) #4
ricow1
On 2014/01/28 09:51:29, kasperl wrote: > LGTM if you update the CL description. Done
6 years, 10 months ago (2014-01-28 09:52:58 UTC) #5
ricow1
Committed patchset #4 manually as r32061 (presubmit successful).
6 years, 10 months ago (2014-01-28 09:55:55 UTC) #6
Bob Nystrom
6 years, 10 months ago (2014-01-28 18:38:09 UTC) #7
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698