Issue 14846022: Use the constant pool for all constants, not just null.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14846022: Use the constant pool for all constants, not just null. (Closed)

Created:
7 years, 7 months ago by Kevin Millikin (Google)

Modified:
7 years, 7 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Use the constant pool for all constants, not just null. Remove constants from the instruction stream in optimized code at SSA construction time. Modify the range analysis pass to analyze values in the constant pool. R=fschneider@google.com Committed: https://code.google.com/p/dart/source/detail?r=22458

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+108 lines, -116 lines)			Patch
M	runtime/vm/flow_graph.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph.cc	View	8 chunks	+24 lines, -20 lines	0 comments	Download
M	runtime/vm/flow_graph_inliner.cc	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.h	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	runtime/vm/flow_graph_optimizer.cc	View	17 chunks	+44 lines, -46 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	18 chunks	+18 lines, -18 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	13 chunks	+19 lines, -23 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Kevin Millikin (Google)

Removing constants makes pattern matching on the instruction stream simpler, with no change in code ...

7 years, 7 months ago (2013-05-07 12:25:56 UTC) #1

Kevin Millikin (Google)

7 years, 7 months ago (2013-05-07 12:50:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r22458 (presubmit successful).

Expand Messages | Collapse Messages