Issue 148453016: Add new Dart API function Dart_IsolateData which returns the peer isolate data associated with an i…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 148453016: Add new Dart API function Dart_IsolateData which returns the peer isolate data associated with an i… (Closed)

Created:
6 years, 10 months ago by siva

Modified:
6 years, 10 months ago

Reviewers:
Ivan Posva

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Add new Dart API function Dart_IsolateData which returns the peer isolate data associated with an isolate. R=iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=32397

Patch Set 3 : #

Created: 6 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -5 lines)			Patch
M	runtime/include/dart_api.h	View	1 2	1 chunk	+10 lines, -2 lines	0 comments	Download
M	runtime/vm/dart_api_impl.cc	View	1	4 chunks	+17 lines, -3 lines	0 comments	Download
M	runtime/vm/dart_api_impl_test.cc	View	1	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Ivan Posva

LGTM -ip https://codereview.chromium.org/148453016/diff/1/runtime/include/dart_api.h File runtime/include/dart_api.h (right): https://codereview.chromium.org/148453016/diff/1/runtime/include/dart_api.h#newcode1010 runtime/include/dart_api.h:1010: * I don't think we should state ...

6 years, 10 months ago (2014-02-07 00:17:46 UTC) #2

siva

https://codereview.chromium.org/148453016/diff/1/runtime/include/dart_api.h File runtime/include/dart_api.h (right): https://codereview.chromium.org/148453016/diff/1/runtime/include/dart_api.h#newcode1010 runtime/include/dart_api.h:1010: * Removed. On 2014/02/07 00:17:46, Ivan Posva wrote: > ...

6 years, 10 months ago (2014-02-07 00:35:42 UTC) #3

siva

6 years, 10 months ago (2014-02-07 00:43:21 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r32397 (presubmit successful).

Expand Messages | Collapse Messages

Issue 148453016: Add new Dart API function Dart_IsolateData which returns the peer isolate data associated with an i… (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages