Speed up web-socket impl by ensuring the optimized compiler is triggered.

Speed up web-socket impl by ensuring the optimized compiler is triggered.

Also cleaned up some fields and made the mask-code slightly better.

BUG=
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32055

[kasperl, 2014-01-27 14:40:07]

https://codereview.chromium.org/148343002/diff/1/sdk/lib/io/websocket_impl.dart
File sdk/lib/io/websocket_impl.dart (right):

https://codereview.chromium.org/148343002/diff/1/sdk/lib/io/websocket_impl.da...
sdk/lib/io/websocket_impl.dart:107: switch (_state) {
Is there one of the cases that's way more likely than the others? Consider
measuring if pulling that check out of the switch helps performance. Maybe even
move the uncommon cases to a different helper method?

https://codereview.chromium.org/148343002/diff/1/sdk/lib/io/websocket_impl.da...
sdk/lib/io/websocket_impl.dart:111: // The RSV1, RSV2 bits RSV3 most be all
zero.
most -> must

https://codereview.chromium.org/148343002/diff/1/sdk/lib/io/websocket_impl.da...
sdk/lib/io/websocket_impl.dart:116: case _WebSocketOpcode.CONTINUATION:
Indent the cases.

https://codereview.chromium.org/148343002/diff/1/sdk/lib/io/websocket_impl.da...
sdk/lib/io/websocket_impl.dart:570: list[i] = data[i] ^ maskBytes[i % 4];
i % 4 -> i & 3 (maybe look for modulo in the code to make this consistent).

[Søren Gjesse, 2014-01-28 00:41:26]

lgtm

https://codereview.chromium.org/148343002/diff/60001/sdk/lib/io/websocket_imp...
File sdk/lib/io/websocket_impl.dart (left):

https://codereview.chromium.org/148343002/diff/60001/sdk/lib/io/websocket_imp...
sdk/lib/io/websocket_impl.dart:258: } catch (e, stackTrace) {
Do we have a test which shows that the protocol errors are still propagated?

https://codereview.chromium.org/148343002/diff/60001/sdk/lib/io/websocket_imp...
File sdk/lib/io/websocket_impl.dart (right):

https://codereview.chromium.org/148343002/diff/60001/sdk/lib/io/websocket_imp...
sdk/lib/io/websocket_impl.dart:194: for (int i = index; i < index + payload;
i++) {
Another optimization option could be to view the Uint8List as an Uint32List and
apply the mask 32-bit at the time. It is somewhat complicated to handle the
alignment issues, but it might be worth it.

[Anders Johnsen, 2014-01-28 08:56:09]

https://codereview.chromium.org/148343002/diff/1/sdk/lib/io/websocket_impl.dart
File sdk/lib/io/websocket_impl.dart (right):

https://codereview.chromium.org/148343002/diff/1/sdk/lib/io/websocket_impl.da...
sdk/lib/io/websocket_impl.dart:107: switch (_state) {
On 2014/01/27 14:40:07, kasperl wrote:
> Is there one of the cases that's way more likely than the others? Consider
> measuring if pulling that check out of the switch helps performance. Maybe
even
> move the uncommon cases to a different helper method?

Moved the switch in to a binary-like if-hierarchy.

https://codereview.chromium.org/148343002/diff/1/sdk/lib/io/websocket_impl.da...
sdk/lib/io/websocket_impl.dart:111: // The RSV1, RSV2 bits RSV3 most be all
zero.
On 2014/01/27 14:40:07, kasperl wrote:
> most -> must

Done.

https://codereview.chromium.org/148343002/diff/1/sdk/lib/io/websocket_impl.da...
sdk/lib/io/websocket_impl.dart:116: case _WebSocketOpcode.CONTINUATION:
On 2014/01/27 14:40:07, kasperl wrote:
> Indent the cases.

Done.

https://codereview.chromium.org/148343002/diff/1/sdk/lib/io/websocket_impl.da...
sdk/lib/io/websocket_impl.dart:570: list[i] = data[i] ^ maskBytes[i % 4];
On 2014/01/27 14:40:07, kasperl wrote:
> i % 4 -> i & 3 (maybe look for modulo in the code to make this consistent).

Done.

https://codereview.chromium.org/148343002/diff/60001/sdk/lib/io/websocket_imp...
File sdk/lib/io/websocket_impl.dart (left):

https://codereview.chromium.org/148343002/diff/60001/sdk/lib/io/websocket_imp...
sdk/lib/io/websocket_impl.dart:258: } catch (e, stackTrace) {
On 2014/01/28 00:41:26, Søren Gjesse wrote:
> Do we have a test which shows that the protocol errors are still propagated? 

Yes, we have several tests that leads to errors.

https://codereview.chromium.org/148343002/diff/60001/sdk/lib/io/websocket_imp...
File sdk/lib/io/websocket_impl.dart (right):

https://codereview.chromium.org/148343002/diff/60001/sdk/lib/io/websocket_imp...
sdk/lib/io/websocket_impl.dart:194: for (int i = index; i < index + payload;
i++) {
On 2014/01/28 00:41:26, Søren Gjesse wrote:
> Another optimization option could be to view the Uint8List as an Uint32List
and
> apply the mask 32-bit at the time. It is somewhat complicated to handle the
> alignment issues, but it might be worth it.

On 32-bit it would mean using non-smis. That sounds somewhat expensive. I'll
keep like this for now, and look into that later on.

[Anders Johnsen, 2014-01-28 08:59:01]

Committed patchset #3 manually as r32055 (presubmit successful).