Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Issue 148283006: Allow copy_coredumps flag on all platforms. (Closed)

Created:
6 years, 10 months ago by ricow1
Modified:
6 years, 10 months ago
Reviewers:
Anders Johnsen
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Allow copy_coredumps flag on all platforms. This will have not effect on winodws/mac yet, since the core file will not be there. Don't try to archive on non linux platforms I will apply this flag on all vm bots - setting this up on system basis is harder, and this is a no-op on mac/windows R=ajohnsen@google.com Committed: https://code.google.com/p/dart/source/detail?r=32117

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -5 lines) Patch
M tools/archive_crash.py View 2 chunks +4 lines, -0 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 chunk +0 lines, -5 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ricow1
6 years, 10 months ago (2014-01-29 11:41:13 UTC) #1
Anders Johnsen
lgtm
6 years, 10 months ago (2014-01-29 11:44:58 UTC) #2
ricow1
6 years, 10 months ago (2014-01-29 11:45:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32117 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698