Issue 148263007: VM: Fix crash when a type error is encountered while evaluating metadata in checked mode.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 148263007: VM: Fix crash when a type error is encountered while evaluating metadata in checked mode. (Closed)

Created:
6 years, 11 months ago by rmacnak

Modified:
6 years, 11 months ago

Reviewers:
gbracha, hausner

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

VM: Fix crash when a type error is encountered while evaluating metadata in checked mode. BUG=http://dartbug.com/16321 R=hausner@google.com Committed: https://code.google.com/p/dart/source/detail?r=32042

Patch Set 1 #

Total comments: 1

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -2 lines)			Patch
M	runtime/vm/parser.cc	View	1 chunk	+5 lines, -2 lines	0 comments	Download
M	tests/lib/lib.status	View	1 chunk	+3 lines, -0 lines	0 comments	Download
A	tests/lib/mirrors/regress_16321_test.dart	View	1 chunk	+21 lines, -0 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

rmacnak

https://codereview.chromium.org/148263007/diff/1/tests/lib/mirrors/regress_16321_test.dart File tests/lib/mirrors/regress_16321_test.dart (right): https://codereview.chromium.org/148263007/diff/1/tests/lib/mirrors/regress_16321_test.dart#newcode15 tests/lib/mirrors/regress_16321_test.dart:15: @TypedBox('foo') /// 01: static type warning Or is the ...

6 years, 11 months ago (2014-01-27 23:07:46 UTC) #1

hausner

Parser change LGTM. Gilad will have to answer your question in the test.

6 years, 11 months ago (2014-01-27 23:33:15 UTC) #2

hausner

I hear that this is a critical fix, so go ahead and check this in. ...

6 years, 11 months ago (2014-01-27 23:36:39 UTC) #3

rmacnak

6 years, 11 months ago (2014-01-27 23:50:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r32042 (presubmit successful).

Expand Messages | Collapse Messages