Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 148223008: Make reflectClassByName work with interceptor names. (Closed)

Created:
6 years, 10 months ago by karlklose
Modified:
6 years, 10 months ago
Reviewers:
floitsch
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Make reflectClassByName work with interceptor names. BUG=16309 R=floitsch@google.com Committed: https://code.google.com/p/dart/source/detail?r=32112

Patch Set 1 #

Patch Set 2 : Add a test #

Total comments: 2

Patch Set 3 : Address comments on test. #

Patch Set 4 : Update lib test expectations. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -1 line) Patch
M sdk/lib/_internal/lib/js_mirrors.dart View 1 chunk +6 lines, -0 lines 0 comments Download
A tests/compiler/dart2js_extra/reflect_native_types_test.dart View 1 2 1 chunk +22 lines, -0 lines 0 comments Download
M tests/lib/lib.status View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
karlklose
6 years, 10 months ago (2014-01-28 15:40:02 UTC) #1
floitsch
LGTM. https://codereview.chromium.org/148223008/diff/10001/tests/compiler/dart2js_extra/reflect_native_types_test.dart File tests/compiler/dart2js_extra/reflect_native_types_test.dart (right): https://codereview.chromium.org/148223008/diff/10001/tests/compiler/dart2js_extra/reflect_native_types_test.dart#newcode10 tests/compiler/dart2js_extra/reflect_native_types_test.dart:10: reflect(123).type.instanceMembers.forEach((k, v) { Do some basic checks and ...
6 years, 10 months ago (2014-01-28 19:35:40 UTC) #2
karlklose
https://codereview.chromium.org/148223008/diff/10001/tests/compiler/dart2js_extra/reflect_native_types_test.dart File tests/compiler/dart2js_extra/reflect_native_types_test.dart (right): https://codereview.chromium.org/148223008/diff/10001/tests/compiler/dart2js_extra/reflect_native_types_test.dart#newcode10 tests/compiler/dart2js_extra/reflect_native_types_test.dart:10: reflect(123).type.instanceMembers.forEach((k, v) { On 2014/01/28 19:35:40, floitsch wrote: > ...
6 years, 10 months ago (2014-01-29 08:55:12 UTC) #3
karlklose
6 years, 10 months ago (2014-01-29 09:50:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #3 manually as r32112 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698