Add Google Charts to Observatory and use it in allocation profiler

Add Google Charts to Observatory and use it in allocation profiler

R=turnidge@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32142

[Cutch, 2014-01-27 19:53:10]

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
File runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart (left):

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/deployed/web/index.html_bootstrap.dart:1: library
app_bootstrap;
This file was never used but accidentally committed in December.

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
File runtime/bin/vmservice/client/lib/src/observatory/request_manager.dart
(left):

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/lib/src/observatory/request_manager.dart:208: if (e
is HttpRequest) {
Fix warning in editor.

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
File runtime/bin/vmservice/client/lib/src/observatory/request_manager.dart
(right):

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/lib/src/observatory/request_manager.dart:59:
'text': error
<error-view tag requires a 'text' entry.

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
File runtime/bin/vmservice/client/precommit.sh (right):

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/precommit.sh:31: cat $INPUT_STANDALONE >
$OUTPUT_STANDALONE
We were rolling both the standalone and the devtools javascript into the
devtools output.

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/precommit.sh:40: # Kill package <script> tags added
by polymer compilation.
This kills console spam.

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/precommit.sh:46: # Fixup <img> src broken by
polymer compilation.
This fixes the Dart icon so that it never results in a broken link.

[turnidge, 2014-01-28 18:28:08]

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
File runtime/bin/vmservice/client/lib/src/observatory/chart.dart (right):

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/lib/src/observatory/chart.dart:8: class Chart
extends Observable {
See my other comment.  I am suggesting getting away from using the static
methods here and making this class own its options, table, and chart objects.

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
File runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.dart
(right):

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.dart:27:
var _newPieChart;
Instead of a making Chart all static, why not make it so that we have Chart
instances that wrap these three things (Options, DataTable, and "Chart")?

It might look like:

_newPie = new Chart('PieChart', shadowRoot.querySelector('#newPieChart'));
_newPie.setOptions({map});
_newPie.addColumn('string', 'Type');
_newPie.clearRows();
_newPie.addRow(['Used', heap['used']]);

This seems a bit simpler to use and read.  It also hides the calls to jsify. 
Let me know if I am missing something.
This is more easily comprehensible to me.

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
File runtime/bin/vmservice/client/precommit.sh (right):

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/precommit.sh:40: # Kill package <script> tags added
by polymer compilation.
On 2014/01/27 19:53:11, Cutch wrote:
> This kills console spam.

Make this a comment in the file.

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/precommit.sh:46: # Fixup <img> src broken by
polymer compilation.
On 2014/01/27 19:53:11, Cutch wrote:
> This fixes the Dart icon so that it never results in a broken link.

Make this a comment in the file.

[Cutch, 2014-01-28 23:23:19]

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
File runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.dart
(right):

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/lib/src/observatory_elements/heap_profile.dart:27:
var _newPieChart;
On 2014/01/28 18:28:08, turnidge wrote:
> Instead of a making Chart all static, why not make it so that we have Chart
> instances that wrap these three things (Options, DataTable, and "Chart")?
> 
> It might look like:
> 
> _newPie = new Chart('PieChart', shadowRoot.querySelector('#newPieChart'));
> _newPie.setOptions({map});
> _newPie.addColumn('string', 'Type');
> _newPie.clearRows();
> _newPie.addRow(['Used', heap['used']]);
> 
> This seems a bit simpler to use and read.  It also hides the calls to jsify. 
> Let me know if I am missing something.
> This is more easily comprehensible to me.
> 

Refactored Chart wrapper.

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
File runtime/bin/vmservice/client/precommit.sh (right):

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/precommit.sh:40: # Kill package <script> tags added
by polymer compilation.
On 2014/01/28 18:28:08, turnidge wrote:
> On 2014/01/27 19:53:11, Cutch wrote:
> > This kills console spam.
> 
> Make this a comment in the file.

Done.

https://codereview.chromium.org/148153007/diff/1/runtime/bin/vmservice/client...
runtime/bin/vmservice/client/precommit.sh:46: # Fixup <img> src broken by
polymer compilation.
On 2014/01/28 18:28:08, turnidge wrote:
> On 2014/01/27 19:53:11, Cutch wrote:
> > This fixes the Dart icon so that it never results in a broken link.
> 
> Make this a comment in the file.

Done.

[turnidge, 2014-01-29 16:55:24]

lgtm

[turnidge, 2014-01-29 16:55:26]

lgtm

[Cutch, 2014-01-29 21:51:38]

Committed patchset #3 manually as r32142 (presubmit successful).