Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 14812016: expose MDV addBindings (Closed)

Created:
7 years, 7 months ago by Jennifer Messerly
Modified:
7 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

expose MDV addBindings this is used to implement Web UI style bindings in the shadowroot template for declarative custom elements. R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=22660

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+93 lines, -18 lines) Patch
M sdk/lib/html/dart2js/html_dart2js.dart View 1 8 chunks +25 lines, -6 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 8 chunks +25 lines, -6 lines 0 comments Download
M tests/html/template_element_test.dart View 1 chunk +18 lines, -0 lines 0 comments Download
M tools/dom/src/TemplateBindings.dart View 1 6 chunks +8 lines, -5 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
M tools/dom/templates/html/impl/impl_HTMLTemplateElement.darttemplate View 1 chunk +16 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jennifer Messerly
I'm not a huge fan of this API, but with luck it is temporary.
7 years, 7 months ago (2013-05-14 03:09:53 UTC) #1
Siggi Cherem (dart-lang)
lgtm
7 years, 7 months ago (2013-05-14 03:18:31 UTC) #2
Jennifer Messerly
7 years, 7 months ago (2013-05-14 03:22:06 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22660 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698