Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(408)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14801010: Fix dartium that was broken by Completer change. (Closed)

Created:
7 years, 7 months ago by floitsch
Modified:
7 years, 7 months ago
Reviewers:
Anton Muhin, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix dartium that was broken by Completer change. BUG= http://dartbug.com/10470 Committed: https://code.google.com/p/dart/source/detail?r=22527

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -6 lines) Patch
M pkg/pkg.status View 1 chunk +0 lines, -3 lines 0 comments Download
M tests/html/html.status View 1 chunk +0 lines, -2 lines 0 comments Download
M tools/dom/src/native_DOMPublic.dart View 1 chunk +1 line, -1 line 3 comments Download

Messages

Total messages: 6 (0 generated)
floitsch
TBR.
7 years, 7 months ago (2013-05-08 19:52:50 UTC) #1
floitsch
Committed patchset #1 manually as r22527 (presubmit successful).
7 years, 7 months ago (2013-05-08 19:58:25 UTC) #2
blois
lgtm
7 years, 7 months ago (2013-05-08 20:02:19 UTC) #3
Anton Muhin
https://codereview.chromium.org/14801010/diff/1/tools/dom/src/native_DOMPublic.dart File tools/dom/src/native_DOMPublic.dart (right): https://codereview.chromium.org/14801010/diff/1/tools/dom/src/native_DOMPublic.dart#newcode8 tools/dom/src/native_DOMPublic.dart:8: final completer = new Completer<SendPort>.sync(); DBQ: do you know ...
7 years, 7 months ago (2013-05-13 09:19:36 UTC) #4
floitsch
https://codereview.chromium.org/14801010/diff/1/tools/dom/src/native_DOMPublic.dart File tools/dom/src/native_DOMPublic.dart (right): https://codereview.chromium.org/14801010/diff/1/tools/dom/src/native_DOMPublic.dart#newcode8 tools/dom/src/native_DOMPublic.dart:8: final completer = new Completer<SendPort>.sync(); On 2013/05/13 09:19:36, Anton ...
7 years, 7 months ago (2013-05-13 09:21:21 UTC) #5
Anton Muhin
7 years, 7 months ago (2013-05-14 13:55:33 UTC) #6
Message was sent while issue was closed. 
https://codereview.chromium.org/14801010/diff/1/tools/dom/src/native_DOMPubli...
File tools/dom/src/native_DOMPublic.dart (right):

https://codereview.chromium.org/14801010/diff/1/tools/dom/src/native_DOMPubli...
tools/dom/src/native_DOMPublic.dart:8: final completer = new
Completer<SendPort>.sync();
Thanks a lot, Florian, I'll have a look.

On 2013/05/13 09:21:21, floitsch wrote:
> On 2013/05/13 09:19:36, Anton Muhin wrote:
> > DBQ: do you know why it's needed?
> 
> Not completely. There must be something that requires the port to be opened
when
> the completer is invoked.

Powered by Google App Engine
This is Rietveld 408576698