Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 147983005: Improved linebreaking for imports (darbug.com/16366) and non-breaking line support. (Closed)

Created:
6 years, 10 months ago by pquitslund
Modified:
6 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Improved linebreaking for imports (darbug.com/16366) and non-breaking line support. R=brianwilkerson@google.com Committed: https://code.google.com/p/dart/source/detail?r=32084

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -18 lines) Patch
M pkg/analyzer/lib/src/services/formatter_impl.dart View 4 chunks +12 lines, -13 lines 0 comments Download
M pkg/analyzer/lib/src/services/writer.dart View 3 chunks +13 lines, -5 lines 0 comments Download
M pkg/analyzer/test/services/data/cu_tests.data View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
pquitslund
6 years, 10 months ago (2014-01-28 21:15:23 UTC) #1
Brian Wilkerson
LGTM
6 years, 10 months ago (2014-01-28 21:32:40 UTC) #2
pquitslund
6 years, 10 months ago (2014-01-28 21:37:09 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r32084 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698