MDV v3 changes: add getInstanceModel for custom syntax

MDV v3 changes: add getInstanceModel for custom syntax
They also simplified TemplateIterator

I added getInstanceFragment, in anticipation of "MDV v4" :)

R=blois@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22591

[Jennifer Messerly, 2013-05-10 01:26:38]

fairly straightforward port of remaining "v3" changes -- mainly
getInstanceModel, since we already had PathObserver. It also looks like
TemplateIterator was simplified too. I just used a diff between my last baseline
to find the changes :)

The changes allow implementing fancier syntax like Angular's in MDV.

[Jennifer Messerly, 2013-05-10 01:44:13]

+siggi too

[Jennifer Messerly, 2013-05-10 05:51:04]

I went ahead and implemented getInstanceFragment too, it seems useful for some
of our web_ui features (such as indentation=remove)

[blois, 2013-05-10 16:07:55]

On 2013/05/10 05:51:04, John Messerly wrote:
> I went ahead and implemented getInstanceFragment too, it seems useful for some
> of our web_ui features (such as indentation=remove)

Any idea if they are planning on using these APIs for sanitization as well?

[blois, 2013-05-10 16:35:08]

lgtm

https://codereview.chromium.org/14793017/diff/6001/tests/html/binding_syntax_...
File tests/html/binding_syntax_test.dart (right):

https://codereview.chromium.org/14793017/diff/6001/tests/html/binding_syntax_...
tests/html/binding_syntax_test.dart:64: expect(div.nodes.length, 4);
Not necessary to change, but for validating the Safe HTML stuff I just made html
that resembled the desired result, then used
https://github.com/blois/safe-dom/blob/master/test/utils.dart#L10 to compare the
DOM trees.

For comparisons where text nodes get combined in the reference, you'd have to
use https://github.com/blois/safe-dom/blob/master/test/utils.dart#L34

[Jennifer Messerly, 2013-05-10 18:22:18]

On 2013/05/10 16:07:55, blois wrote:
> On 2013/05/10 05:51:04, John Messerly wrote:
> > I went ahead and implemented getInstanceFragment too, it seems useful for
some
> > of our web_ui features (such as indentation=remove)
> 
> Any idea if they are planning on using these APIs for sanitization as well?

No idea :)

I think you could implement attribute sanitation in terms of "getBinding", then
filter out certain names.


On 2013/05/10 16:35:08, blois wrote:
> lgtm
> 
>
https://codereview.chromium.org/14793017/diff/6001/tests/html/binding_syntax_...
> File tests/html/binding_syntax_test.dart (right):
> 
>
https://codereview.chromium.org/14793017/diff/6001/tests/html/binding_syntax_...
> tests/html/binding_syntax_test.dart:64: expect(div.nodes.length, 4);
> Not necessary to change, but for validating the Safe HTML stuff I just made
html
> that resembled the desired result, then used
> https://github.com/blois/safe-dom/blob/master/test/utils.dart#L10 to compare
the
> DOM trees.
> 
> For comparisons where text nodes get combined in the reference, you'd have to
> use https://github.com/blois/safe-dom/blob/master/test/utils.dart#L34

yeah, that would be nice :). Are you planning to add that to tests/html? I'll
keep an eye out for it in future changes.

[Jennifer Messerly, 2013-05-10 18:59:46]

Committed patchset #4 manually as r22591 (presubmit successful).

[Siggi Cherem (dart-lang), 2013-05-10 20:11:28]

gltm!

[Siggi Cherem (dart-lang), 2013-05-10 20:11:54]

On 2013/05/10 20:11:28, Siggi Cherem (dart-lang) wrote:
> gltm!

(that's yoda saying lgtm =))