Issue 14793016: pkg/serialization types cleanup

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14793016: pkg/serialization types cleanup (Closed)

Created:
7 years, 7 months ago by kevmoo-old

Modified:
7 years, 7 months ago

Reviewers:
Alan Knight

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

pkg/serialization types cleanup Hide a few things, fix return types, make a few things final, etc. R=alanknight@google.com Committed: https://code.google.com/p/dart/source/detail?r=22524

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+90 lines, -89 lines)			Patch
M	pkg/serialization/lib/serialization.dart	View		5 chunks	+7 lines, -13 lines	0 comments	Download
M	pkg/serialization/lib/src/basic_rule.dart	View		17 chunks	+29 lines, -29 lines	0 comments	Download
M	pkg/serialization/lib/src/format.dart	View	1	8 chunks	+19 lines, -12 lines	0 comments	Download
M	pkg/serialization/lib/src/reader_writer.dart	View	1	14 chunks	+20 lines, -20 lines	0 comments	Download
M	pkg/serialization/lib/src/serialization_rule.dart	View		2 chunks	+4 lines, -4 lines	0 comments	Download
M	pkg/serialization/test/serialization_test.dart	View	1	8 chunks	+11 lines, -11 lines	0 comments	Download

Total messages: 3 (0 generated)

Alan Knight

LGTM, thanks! With a dynamic language background, I tend to not think about the types.

7 years, 7 months ago (2013-05-08 17:48:09 UTC) #2

kevmoo-old

7 years, 7 months ago (2013-05-08 18:59:48 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r22524 (presubmit successful).