Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 147923003: Compile spawnUri entrypoints to JS with pub build/serve. (Closed)

Created:
6 years, 10 months ago by nweiz
Modified:
6 years, 10 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Compile spawnUri entrypoints to JS with pub build/serve. R=rnystrom@google.com BUG=16210 Committed: https://code.google.com/p/dart/source/detail?r=32093

Patch Set 1 #

Total comments: 2

Patch Set 2 : code review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M sdk/lib/_internal/pub/lib/src/dart.dart View 1 1 chunk +4 lines, -1 line 0 comments Download
A + sdk/lib/_internal/pub/test/transformer/dart2js/converts_isolate_entrypoint_in_web_test.dart View 1 chunk +4 lines, -3 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
nweiz
6 years, 10 months ago (2014-01-28 20:45:37 UTC) #1
Bob Nystrom
https://codereview.chromium.org/147923003/diff/1/sdk/lib/_internal/pub/lib/src/dart.dart File sdk/lib/_internal/pub/lib/src/dart.dart (right): https://codereview.chromium.org/147923003/diff/1/sdk/lib/_internal/pub/lib/src/dart.dart#newcode114 sdk/lib/_internal/pub/lib/src/dart.dart:114: node.functionExpression.parameters.parameters.length <= 3; Add a comment explaining this. Also, ...
6 years, 10 months ago (2014-01-28 21:26:16 UTC) #2
nweiz
https://codereview.chromium.org/147923003/diff/1/sdk/lib/_internal/pub/lib/src/dart.dart File sdk/lib/_internal/pub/lib/src/dart.dart (right): https://codereview.chromium.org/147923003/diff/1/sdk/lib/_internal/pub/lib/src/dart.dart#newcode114 sdk/lib/_internal/pub/lib/src/dart.dart:114: node.functionExpression.parameters.parameters.length <= 3; On 2014/01/28 21:26:16, Bob Nystrom wrote: ...
6 years, 10 months ago (2014-01-28 22:16:45 UTC) #3
Bob Nystrom
6 years, 10 months ago (2014-01-28 22:46:12 UTC) #4
Bob Nystrom
lgtm
6 years, 10 months ago (2014-01-28 22:46:19 UTC) #5
nweiz
6 years, 10 months ago (2014-01-28 23:07:55 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 manually as r32093 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698