Issue 14786020: Update status files for 'dartanalyer'.

Issue 14786020: Update status files for 'dartanalyer'. (Closed)

Created:
7 years, 7 months ago by scheglov

Modified:
7 years, 7 months ago

Reviewers:
devoncarew

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Update status files for 'dartanalyer'. Small tweak for the Java command line analyzer to actually support --package-root option in batch. R=devoncarew@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22480

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added missing status files. #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+795 lines, -25 lines)			Patch
M	editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerMain.java	View		9 chunks	+13 lines, -13 lines	0 comments	Download
M	editor/tools/plugins/com.google.dart.command.analyze/src/com/google/dart/command/analyze/AnalyzerOptions.java	View		2 chunks	+12 lines, -11 lines	0 comments	Download
M	pkg/pkg.status	View		1 chunk	+3 lines, -0 lines	0 comments	Download
A	tests/co19/co19-analyzer.status	View	1	1 chunk	+333 lines, -0 lines	0 comments	Download
M	tests/co19/test_config.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/corelib/corelib.status	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/isolate/isolate.status	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	tests/language/language.status	View		1 chunk	+405 lines, -0 lines	0 comments	Download
M	tests/lib/analyzer/analyze_tests.status	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	tests/standalone/standalone.status	View		1 chunk	+11 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

devoncarew

lgtm Looks good, modulo one missing file. https://codereview.chromium.org/14786020/diff/1/tests/co19/test_config.dart File tests/co19/test_config.dart (right): https://codereview.chromium.org/14786020/diff/1/tests/co19/test_config.dart#newcode17 tests/co19/test_config.dart:17: ["tests/co19/co19-analyzer.status", Do ...

7 years, 7 months ago (2013-05-07 20:50:00 UTC) #2

scheglov

Thank you, fixed. https://codereview.chromium.org/14786020/diff/1/tests/co19/test_config.dart File tests/co19/test_config.dart (right): https://codereview.chromium.org/14786020/diff/1/tests/co19/test_config.dart#newcode17 tests/co19/test_config.dart:17: ["tests/co19/co19-analyzer.status", On 2013/05/07 20:50:00, devoncarew wrote: ...

7 years, 7 months ago (2013-05-07 20:52:49 UTC) #3

scheglov

7 years, 7 months ago (2013-05-07 21:45:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r22480 (presubmit successful).

Expand Messages | Collapse Messages