Issue 14784010: Third step towards loading core library scripts directly from the sources

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14784010: Third step towards loading core library scripts directly from the sources (Closed)

Created:
7 years, 7 months ago by siva

Modified:
7 years, 7 months ago

Reviewers:
hausner, Ivan Posva

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Third step towards loading core library scripts directly from the sources - Read the patch source files using the source mapping array generated for patch files instead of relying on a generated buffer containing the sources. - Modify the gyp files to ensure that all patch libraries are read directly from the sources. Remove the source buffer generation step in the gypi files for all patch files. R=hausner@google.com, iposva@google.com Committed: https://code.google.com/p/dart/source/detail?r=22436

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+133 lines, -98 lines)			Patch
M	runtime/lib/date_patch.dart	View	2 chunks	+13 lines, -12 lines	0 comments	Download
M	runtime/tools/gen_library_src_paths.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/vm/bootstrap.h	View	1 chunk	+10 lines, -10 lines	0 comments	Download
M	runtime/vm/bootstrap.cc	View	7 chunks	+55 lines, -31 lines	0 comments	Download
M	runtime/vm/vm.gypi	View	18 chunks	+54 lines, -45 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

7 years, 7 months ago (2013-05-06 18:16:30 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r22436 (presubmit successful).

Expand Messages | Collapse Messages