Issue 14783002: Loosen aggressive assert in debugger stack trace code

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14783002: Loosen aggressive assert in debugger stack trace code (Closed)

Created:
7 years, 7 months ago by hausner

Modified:
7 years, 7 months ago

Reviewers:
siva

CC:
reviews_dartlang.org, Jacob

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Loosen aggressive assert in debugger stack trace code A closure may be called from native code. In that case we will not find a saved context variable in the dart frame 'below' the closure. R=asiva@google.com Committed: https://code.google.com/p/dart/source/detail?r=22268

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -24 lines)			Patch
	M	runtime/vm/debugger.cc	View	1	2 chunks	+22 lines, -24 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

siva

lgtm https://codereview.chromium.org/14783002/diff/1/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/14783002/diff/1/runtime/vm/debugger.cc#newcode925 runtime/vm/debugger.cc:925: printf("CollectStackTrace error: no saved context in function " ...

7 years, 7 months ago (2013-05-01 18:21:19 UTC) #2

hausner

Thank you. https://codereview.chromium.org/14783002/diff/1/runtime/vm/debugger.cc File runtime/vm/debugger.cc (right): https://codereview.chromium.org/14783002/diff/1/runtime/vm/debugger.cc#newcode925 runtime/vm/debugger.cc:925: printf("CollectStackTrace error: no saved context in function ...

7 years, 7 months ago (2013-05-01 18:32:53 UTC) #3

hausner

7 years, 7 months ago (2013-05-01 18:34:52 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r22268 (presubmit successful).

Expand Messages | Collapse Messages