classes with call-methods were not recognized as Functions.

classes with call-methods were not recognized as Functions.

Also fixes similar issue (classes with 'call' getter were recognized as Function).

BUG= http://dartbug.com/16401
R=johnniwinther@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32252

[ngeoffray, 2014-01-31 23:32:41]

DBC

https://codereview.chromium.org/147743005/diff/30001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right):

https://codereview.chromium.org/147743005/diff/30001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/elements/elements.dart:910: ///
Returns true if `this` implements [intrface].
if `this` explicitly/nominally implements [intrface]. Note that if [intrface] is
the `Function` class, this method will return false to a class that has a 
[call] method but does not explicitly implement Function.

?

[floitsch, 2014-01-31 23:36:23]

https://codereview.chromium.org/147743005/diff/30001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right):

https://codereview.chromium.org/147743005/diff/30001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/elements/elements.dart:910: ///
Returns true if `this` implements [intrface].
On 2014/01/31 23:32:41, ngeoffray wrote:
> if `this` explicitly/nominally implements [intrface]. Note that if [intrface]
is
> the `Function` class, this method will return false to a class that has a 
> [call] method but does not explicitly implement Function.
> 
> ?

Done.

[Johnni Winther, 2014-02-03 08:27:25]

lgtm

https://codereview.chromium.org/147743005/diff/80001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right):

https://codereview.chromium.org/147743005/diff/80001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/elements/elements.dart:910: ///
Returns true if `this` exlicitly/nominally implements [intrface].
'exlicitly' -> 'explicitly'

https://codereview.chromium.org/147743005/diff/80001/tests/language/function_...
File tests/language/function_type_call_getter2_test.dart (right):

https://codereview.chromium.org/147743005/diff/80001/tests/language/function_...
tests/language/function_type_call_getter2_test.dart:27: Function  /// 00: static
type warning, dynamic type error
These should not cause static type warnings since a, b, and c are declared as
var.

[floitsch, 2014-02-03 17:43:20]

https://codereview.chromium.org/147743005/diff/80001/sdk/lib/_internal/compil...
File sdk/lib/_internal/compiler/implementation/elements/elements.dart (right):

https://codereview.chromium.org/147743005/diff/80001/sdk/lib/_internal/compil...
sdk/lib/_internal/compiler/implementation/elements/elements.dart:910: ///
Returns true if `this` exlicitly/nominally implements [intrface].
On 2014/02/03 08:27:25, Johnni Winther wrote:
> 'exlicitly' -> 'explicitly'

Done.

https://codereview.chromium.org/147743005/diff/80001/tests/language/function_...
File tests/language/function_type_call_getter2_test.dart (right):

https://codereview.chromium.org/147743005/diff/80001/tests/language/function_...
tests/language/function_type_call_getter2_test.dart:27: Function  /// 00: static
type warning, dynamic type error
On 2014/02/03 08:27:25, Johnni Winther wrote:
> These should not cause static type warnings since a, b, and c are declared as
> var.

Argh. Marked them as "A", "B" and "C".
done.

[floitsch, 2014-02-03 17:45:11]

Committed patchset #5 manually as r32252 (presubmit successful).