Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 14773027: Fix regression in meta-serializing rules (Closed)

Created:
7 years, 7 months ago by Alan Knight
Modified:
7 years, 7 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix regression in meta-serializing rules R=jmesserly@google.com Committed: https://code.google.com/p/dart/source/detail?r=22603

Patch Set 1 #

Patch Set 2 : Add a test case and fix the no_library_test #

Patch Set 3 : Slight improvement for the case of duplicate library names #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -7 lines) Patch
M pkg/serialization/lib/serialization.dart View 1 4 chunks +6 lines, -4 lines 0 comments Download
M pkg/serialization/lib/src/serialization_rule.dart View 1 2 1 chunk +16 lines, -3 lines 0 comments Download
M pkg/serialization/test/serialization_test.dart View 1 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Alan Knight
Adding Symbols to the library broke the ability to meta-serialize rules. This wasn't noticed, because ...
7 years, 7 months ago (2013-05-10 17:32:16 UTC) #1
Jennifer Messerly
lgtm
7 years, 7 months ago (2013-05-10 22:08:51 UTC) #2
Alan Knight
7 years, 7 months ago (2013-05-10 22:15:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #3 manually as r22603 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698