Report MIXIN_INHERITS_FROM_NOT_OBJECT

Report MIXIN_INHERITS_FROM_NOT_OBJECT

R=brianwilkerson@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=22559

[Brian Wilkerson, 2013-05-09 18:38:20]

LGTM

https://codereview.chromium.org/14773018/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java
(right):

https://codereview.chromium.org/14773018/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java:582:
"Superclass of the class '%s' is is not the Object and cannot be used as a
mixin"),
Perhaps reword to

The class '%s' cannot be used as a mixin because it extends a class other than
Object

We could then make MIXIN_DECLARES_CONSTRUCTOR consistent by rewording it to

The class '%s' cannot be used as a mixin because it defines a constructor

nit: Neither this nor MIXIN_DECLARES_CONSTRUCTOR have a @param tag, while
MIXIN_OF_NON_CLASS has one when the message doesn't take a parameter.

https://codereview.chromium.org/14773018/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
(right):

https://codereview.chromium.org/14773018/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:1500:
private boolean checkForMixinInheritsNotFromObject(WithClause withClause) {
It might be more efficient to iterate over the list of mixins exactly once and
produce all possible errors. It would also allow us to decide whether to produce
multiple errors for a single mixin.

[scheglov, 2013-05-09 19:35:06]

Committed patchset #2 manually as r22559 (presubmit successful).

[scheglov, 2013-05-09 19:35:36]

https://codereview.chromium.org/14773018/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java
(right):

https://codereview.chromium.org/14773018/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/error/CompileTimeErrorCode.java:582:
"Superclass of the class '%s' is is not the Object and cannot be used as a
mixin"),
On 2013/05/09 18:38:20, Brian Wilkerson wrote:
> Perhaps reword to
> 
> The class '%s' cannot be used as a mixin because it extends a class other than
> Object
> 
> We could then make MIXIN_DECLARES_CONSTRUCTOR consistent by rewording it to
> 
> The class '%s' cannot be used as a mixin because it defines a constructor
> 
> nit: Neither this nor MIXIN_DECLARES_CONSTRUCTOR have a @param tag, while
> MIXIN_OF_NON_CLASS has one when the message doesn't take a parameter.

Done.

https://codereview.chromium.org/14773018/diff/1/editor/tools/plugins/com.goog...
File
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java
(right):

https://codereview.chromium.org/14773018/diff/1/editor/tools/plugins/com.goog...
editor/tools/plugins/com.google.dart.engine/src/com/google/dart/engine/internal/verifier/ErrorVerifier.java:1500:
private boolean checkForMixinInheritsNotFromObject(WithClause withClause) {
On 2013/05/09 18:38:20, Brian Wilkerson wrote:
> It might be more efficient to iterate over the list of mixins exactly once and
> produce all possible errors. It would also allow us to decide whether to
produce
> multiple errors for a single mixin.

Done.