Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issue 14772041: Now that we inline instance methods on all kinds of receivers (not only "this" calls), we need to d… (Closed)

Created:
7 years, 7 months ago by ngeoffray
Modified:
7 years, 7 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Now that we inline instance methods on all kinds of receivers (not only "this" calls), we need to do an explicit null check. R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=22734

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M sdk/lib/_internal/compiler/implementation/ssa/builder.dart View 1 1 chunk +8 lines, -0 lines 0 comments Download
A tests/language/null_inline_test.dart View 1 chunk +19 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
ngeoffray
7 years, 7 months ago (2013-05-15 12:33:18 UTC) #1
karlklose
LGTM.
7 years, 7 months ago (2013-05-15 13:14:57 UTC) #2
ngeoffray
7 years, 7 months ago (2013-05-15 13:16:31 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r22734 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698