Issue 14767014: Dart-based command-line analyzer.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14767014: Dart-based command-line analyzer. (Closed)

Created:
7 years, 7 months ago by scheglov

Modified:
7 years, 7 months ago

Reviewers:
pquitslund

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Dart-based command-line analyzer. R=pquitslund@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22385

Patch Set 1 #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+429 lines, -43 lines)			Patch
M	pkg/analyzer_experimental/bin/analyzer.dart	View	1 chunk	+104 lines, -24 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/analyzer.dart	View	1 chunk	+130 lines, -0 lines	0 comments	Download
A	pkg/analyzer_experimental/lib/error_formatter.dart	View	1 chunk	+143 lines, -0 lines	0 comments	Download
M	pkg/analyzer_experimental/lib/options.dart	View	5 chunks	+52 lines, -19 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

pquitslund

LGTM. Fantastic. In the long (or short) run, I recommend getting a once-over from someone ...

7 years, 7 months ago (2013-05-03 17:14:05 UTC) #2

scheglov

Committed patchset #1 manually as r22385 (presubmit successful).

7 years, 7 months ago (2013-05-03 18:34:46 UTC) #3

nweiz

7 years, 7 months ago (2013-05-08 00:48:13 UTC) #4

Message was sent while issue was closed.

On 2013/05/03 16:12:37, scheglov wrote:

For future reference, part files don't belong at the top level of "lib". The
only files that should be there are libraries that are meant to be imported by
users of the package.

I'm working on a CL right now to add some utility functions to this library, and
as part of that I'm planning on moving these files into src.

Expand Messages | Collapse Messages