Issue 14766003: Add v6Only named argument to ServerSocket and etc.

Issue 14766003: Add v6Only named argument to ServerSocket and etc. (Closed)

Created:
7 years, 7 months ago by Anders Johnsen

Modified:
7 years, 7 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Add v6Only named argument to ServerSocket and etc. BUG= R=sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=22309

Patch Set 2 : Merge #

Total comments: 2

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+65 lines, -27 lines)			Patch
M	runtime/bin/io_natives.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/bin/socket.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	runtime/bin/socket.cc	View	1 chunk	+4 lines, -1 line	0 comments	Download
M	runtime/bin/socket_android.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/bin/socket_linux.cc	View	2 chunks	+3 lines, -2 lines	2 comments	Download
M	runtime/bin/socket_macos.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	runtime/bin/socket_patch.dart	View	8 chunks	+18 lines, -11 lines	0 comments	Download
M	runtime/bin/socket_win.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	sdk/lib/io/secure_server_socket.dart	View	3 chunks	+4 lines, -1 line	0 comments	Download
M	sdk/lib/io/socket.dart	View	5 chunks	+7 lines, -4 lines	0 comments	Download
M	tests/standalone/io/socket_ipv6_test.dart	View	2 chunks	+17 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/14766003/diff/2001/runtime/bin/socket_linux.cc File runtime/bin/socket_linux.cc (right): https://codereview.chromium.org/14766003/diff/2001/runtime/bin/socket_linux.cc#newcode224 runtime/bin/socket_linux.cc:224: optval = v6_only ? 1 : 0; Isn't ...

7 years, 7 months ago (2013-05-01 12:27:47 UTC) #2

Anders Johnsen

https://codereview.chromium.org/14766003/diff/2001/runtime/bin/socket_linux.cc File runtime/bin/socket_linux.cc (right): https://codereview.chromium.org/14766003/diff/2001/runtime/bin/socket_linux.cc#newcode224 runtime/bin/socket_linux.cc:224: optval = v6_only ? 1 : 0; On 2013/05/01 ...

7 years, 7 months ago (2013-05-01 12:30:04 UTC) #3

Anders Johnsen

7 years, 7 months ago (2013-05-02 11:23:51 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r22309 (presubmit successful).

Expand Messages | Collapse Messages