Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 14762008: Use "self" not "window" for Worker API. (Closed)

Created:
7 years, 7 months ago by ahe
Modified:
7 years, 7 months ago
Reviewers:
sra1, blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use "self" not "window" for Worker API. R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=22697

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -4 lines) Patch
M dart/sdk/lib/html/dart2js/html_dart2js.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M dart/tests/html/html.status View 1 chunk +1 line, -0 lines 0 comments Download
A dart/tests/html/worker_api_test.dart View 1 chunk +31 lines, -0 lines 0 comments Download
M dart/tools/dom/templates/html/dart2js/impl_URL.darttemplate View 1 chunk +2 lines, -2 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
ahe
7 years, 7 months ago (2013-05-13 17:41:42 UTC) #1
blois
https://codereview.chromium.org/14762008/diff/1/dart/tools/dom/templates/html/dart2js/impl_URL.darttemplate File dart/tools/dom/templates/html/dart2js/impl_URL.darttemplate (right): https://codereview.chromium.org/14762008/diff/1/dart/tools/dom/templates/html/dart2js/impl_URL.darttemplate#newcode11 dart/tools/dom/templates/html/dart2js/impl_URL.darttemplate:11: '(self.URL || self.webkitURL).createObjectURL(#)', I believe it should probably be: ...
7 years, 7 months ago (2013-05-13 17:47:52 UTC) #2
ahe
https://codereview.chromium.org/14762008/diff/1/dart/tools/dom/templates/html/dart2js/impl_URL.darttemplate File dart/tools/dom/templates/html/dart2js/impl_URL.darttemplate (right): https://codereview.chromium.org/14762008/diff/1/dart/tools/dom/templates/html/dart2js/impl_URL.darttemplate#newcode11 dart/tools/dom/templates/html/dart2js/impl_URL.darttemplate:11: '(self.URL || self.webkitURL).createObjectURL(#)', On 2013/05/13 17:47:52, blois wrote: > ...
7 years, 7 months ago (2013-05-13 18:32:22 UTC) #3
blois
lgtm
7 years, 7 months ago (2013-05-13 18:33:45 UTC) #4
ahe
7 years, 7 months ago (2013-05-14 18:35:35 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 manually as r22697 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698