Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Issue 14761002: Preserve nullability when writing idl with the ildrenderer. Use nullability to call the toNativeWit… (Closed)

Created:
7 years, 7 months ago by Mads Ager (google)
Modified:
7 years, 7 months ago
Reviewers:
vsm, Anton Muhin
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Preserve nullability when writing idl with the ildrenderer. Use nullability to call the toNativeWithNullCheck variant of conversion functions in dartium. R=antonm@google.com, vsm@google.com BUG=dartbug.com/3890 Committed: https://code.google.com/p/dart/source/detail?r=22226

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M tools/dom/scripts/idlrenderer.py View 1 chunk +4 lines, -1 line 0 comments Download
M tools/dom/scripts/systemnative.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mads Ager (google)
7 years, 7 months ago (2013-05-01 08:37:32 UTC) #1
Mads Ager (google)
tbr
7 years, 7 months ago (2013-05-01 09:01:48 UTC) #2
Mads Ager (google)
Committed patchset #1 manually as r22226 (presubmit successful).
7 years, 7 months ago (2013-05-01 09:02:05 UTC) #3
vsm
7 years, 7 months ago (2013-05-02 04:30:21 UTC) #4
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698