More sophisticated handling of parameter metadata.

More sophisticated handling of parameter metadata.

This tries to produce better output in parameter lists with lots of or
very long metadata annotations. The rules are:

- If any metadata annotation splits, all of the ones in the parameter
  list do.
- If so, the parameters are indented to distinguish them in the list.

Fix #387. Fix #444.

R=nweiz@google.com

Committed: https://github.com/dart-lang/dart_style/commit/7da513548ba418af46eac5be1bc73afaa96895db

[Bob Nystrom, 2015-11-25 01:20:05]

rnystrom@google.com changed reviewers:
+ nweiz@google.com

[nweiz, 2015-11-30 19:17:01]

lgtm

https://codereview.chromium.org/1475873002/diff/1/lib/src/rule/metadata.dart
File lib/src/rule/metadata.dart (right):

https://codereview.chromium.org/1475873002/diff/1/lib/src/rule/metadata.dart#...
lib/src/rule/metadata.dart:42: if (value == 0) return null;
Consider making a getter for "value == 0", like isNotSplit or something like
that.

https://codereview.chromium.org/1475873002/diff/1/lib/src/source_visitor.dart
File lib/src/source_visitor.dart (right):

https://codereview.chromium.org/1475873002/diff/1/lib/src/source_visitor.dart...
lib/src/source_visitor.dart:1646: // as well?
The doc comment for MetadataRule implies that it does. If it doesn't yet, that
comment should be updated.

[Bob Nystrom, 2015-11-30 21:35:39]

Description was changed from

==========
More sophisticated handling of parameter metadata.

This tries to produce better output in parameter lists with lots of or
very long metadata annotations. The rules are:

- If any metadata annotation splits, all of the ones in the parameter
  list do.
- If so, the parameters are indented to distinguish them in the list.

Fix #387. Fix #444.
==========

to

==========
More sophisticated handling of parameter metadata.

This tries to produce better output in parameter lists with lots of or
very long metadata annotations. The rules are:

- If any metadata annotation splits, all of the ones in the parameter
  list do.
- If so, the parameters are indented to distinguish them in the list.

Fix #387. Fix #444.

R=nweiz@google.com

Committed:
https://github.com/dart-lang/dart_style/commit/7da513548ba418af46eac5be1bc73a...
==========

[Bob Nystrom, 2015-11-30 21:35:40]

Committed patchset #1 (id:1) manually as
7da513548ba418af46eac5be1bc73afaa96895db (presubmit successful).

[Bob Nystrom, 2015-11-30 21:36:14]

Thanks!

https://codereview.chromium.org/1475873002/diff/1/lib/src/rule/metadata.dart
File lib/src/rule/metadata.dart (right):

https://codereview.chromium.org/1475873002/diff/1/lib/src/rule/metadata.dart#...
lib/src/rule/metadata.dart:42: if (value == 0) return null;
On 2015/11/30 19:17:01, nweiz wrote:
> Consider making a getter for "value == 0", like isNotSplit or something like
> that.

Done.

https://codereview.chromium.org/1475873002/diff/1/lib/src/source_visitor.dart
File lib/src/source_visitor.dart (right):

https://codereview.chromium.org/1475873002/diff/1/lib/src/source_visitor.dart...
lib/src/source_visitor.dart:1646: // as well?
On 2015/11/30 19:17:01, nweiz wrote:
> The doc comment for MetadataRule implies that it does. If it doesn't yet, that
> comment should be updated.

Done.