Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issue 14757002: Mark test/install/git/dependency_name_match_pubspec_test as Skip (Closed)

Created:
7 years, 7 months ago by ricow1
Modified:
7 years, 7 months ago
Reviewers:
Bob Nystrom, kustermann
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Mark test/install/git/dependency_name_match_pubspec_test as Skip This is failing on normal windows, but passing on russian locale. Upped issue 10348 to high priority R=kustermann@google.com Committed: https://code.google.com/p/dart/source/detail?r=22224

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M sdk/lib/_internal/pub/pub.status View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ricow1
7 years, 7 months ago (2013-05-01 08:09:44 UTC) #1
ricow1
Marking as flaky instead so that we get entries in the flaky log
7 years, 7 months ago (2013-05-01 08:13:05 UTC) #2
kustermann
lgtm
7 years, 7 months ago (2013-05-01 08:15:18 UTC) #3
ricow1
Committed patchset #2 manually as r22224 (presubmit successful).
7 years, 7 months ago (2013-05-01 08:21:57 UTC) #4
Bob Nystrom
7 years, 7 months ago (2013-05-01 16:03:55 UTC) #5
Message was sent while issue was closed.
Thanks, I'll take a look.

Powered by Google App Engine
This is Rietveld 408576698