Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 14756007: Fix issue 10487 by adapting the type checker so it uses the dynamic type for throw expressions. (Closed)

Created:
7 years, 7 months ago by kasperl
Modified:
7 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix issue 10487 by adapting the type checker so it uses the dynamic type for throw expressions. R=johnniwinther@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=22501

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
M sdk/lib/_internal/compiler/implementation/typechecker.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M tests/language/throw_expr_test.dart View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
kasperl
7 years, 7 months ago (2013-05-08 09:13:55 UTC) #1
Johnni Winther
LGTM Looks like a short-term solution. We probably need to investigate the interplay between (sub)type ...
7 years, 7 months ago (2013-05-08 09:23:37 UTC) #2
kasperl
On 2013/05/08 09:23:37, Johnni Winther wrote: > LGTM > > Looks like a short-term solution. ...
7 years, 7 months ago (2013-05-08 09:27:53 UTC) #3
kasperl
7 years, 7 months ago (2013-05-08 09:28:37 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r22501 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698