Enable parsing of IPv6 form addresse (see rfc2373 and rfc2732).

Enable parsing of IPv6 form addresse (see rfc2373 and rfc2732).

This also wraps the 'domain' component in toString with [...], if it
contains any ':' characters.

BUG=
R=floitsch@google.com, sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=22228

[Søren Gjesse, 2013-05-01 07:46:58]

lgtm

https://codereview.chromium.org/14753005/diff/1/sdk/lib/uri/uri.dart
File sdk/lib/uri/uri.dart (right):

https://codereview.chromium.org/14753005/diff/1/sdk/lib/uri/uri.dart#newcode16
sdk/lib/uri/uri.dart:16: * [RFC-3986]:
http://tools.ietf.org/html/rfc3986#section-4.3)
Add some more documentation on domain hostname/IPv4 address/IPv6 address, and
then fact that []'s are added in toString?

https://codereview.chromium.org/14753005/diff/1/sdk/lib/uri/uri.dart#newcode28
sdk/lib/uri/uri.dart:28: * Deprecated. Please use [parse] instead.
Remove this while at it?

https://codereview.chromium.org/14753005/diff/1/tests/lib/uri/uri_ipv6_test.dart
File tests/lib/uri/uri_ipv6_test.dart (right):

https://codereview.chromium.org/14753005/diff/1/tests/lib/uri/uri_ipv6_test.d...
tests/lib/uri/uri_ipv6_test.dart:9: void testValidIpv6Uri() {
Add tests of all examples in RFC2732
      http://[FEDC:BA98:7654:3210:FEDC:BA98:7654:3210]:80/index.html
      http://[1080:0:0:0:8:800:200C:417A]/index.html
      http://[3ffe:2a00:100:7031::1]
      http://[1080::8:800:200C:417A]/foo
      http://[::192.9.5.5]/ipng
      http://[::FFFF:129.144.52.38]:80/index.html
      http://[2010:836B:4179::836B:4179]

?

[Anders Johnsen, 2013-05-01 08:07:27]

PTAL

https://codereview.chromium.org/14753005/diff/1/sdk/lib/uri/uri.dart
File sdk/lib/uri/uri.dart (right):

https://codereview.chromium.org/14753005/diff/1/sdk/lib/uri/uri.dart#newcode16
sdk/lib/uri/uri.dart:16: * [RFC-3986]:
http://tools.ietf.org/html/rfc3986#section-4.3)
On 2013/05/01 07:46:58, Søren Gjesse wrote:
> Add some more documentation on domain hostname/IPv4 address/IPv6 address, and
> then fact that []'s are added in toString?

Done.

https://codereview.chromium.org/14753005/diff/1/sdk/lib/uri/uri.dart#newcode28
sdk/lib/uri/uri.dart:28: * Deprecated. Please use [parse] instead.
On 2013/05/01 07:46:58, Søren Gjesse wrote:
> Remove this while at it?

I'll wait a bit.

https://codereview.chromium.org/14753005/diff/1/tests/lib/uri/uri_ipv6_test.dart
File tests/lib/uri/uri_ipv6_test.dart (right):

https://codereview.chromium.org/14753005/diff/1/tests/lib/uri/uri_ipv6_test.d...
tests/lib/uri/uri_ipv6_test.dart:9: void testValidIpv6Uri() {
On 2013/05/01 07:46:58, Søren Gjesse wrote:
> Add tests of all examples in RFC2732
>       http://%5BFEDC:BA98:7654:3210:FEDC:BA98:7654:3210%5D:80/index.html
>       http://%5B1080:0:0:0:8:800:200C:417A%5D/index.html
>       http://%5B3ffe:2a00:100:7031::1%5D
>       http://%5B1080::8:800:200C:417A%5D/foo
>       http://%5B::192.9.5.5%5D/ipng
>       http://%5B::FFFF:129.144.52.38%5D:80/index.html
>       http://%5B2010:836B:4179::836B:4179%5D
> 
> ?

Done.

[floitsch, 2013-05-01 08:53:30]

LGTM.

https://codereview.chromium.org/14753005/diff/5001/sdk/lib/uri/uri.dart
File sdk/lib/uri/uri.dart (right):

https://codereview.chromium.org/14753005/diff/5001/sdk/lib/uri/uri.dart#newco...
sdk/lib/uri/uri.dart:18: * '[' and ']' around the part.
which part?

https://codereview.chromium.org/14753005/diff/5001/sdk/lib/uri/uri.dart#newco...
sdk/lib/uri/uri.dart:19: * [uri]:
http://closure-library.googlecode.com/svn/docs/class_goog_Uri.html
URI ?

https://codereview.chromium.org/14753005/diff/5001/sdk/lib/uri/uri.dart#newco...
sdk/lib/uri/uri.dart:33: * Deprecated. Please use [parse] instead.
Now that I see it: yes. Please get rid of it.

https://codereview.chromium.org/14753005/diff/5001/sdk/lib/uri/uri.dart#newco...
sdk/lib/uri/uri.dart:86: '([\\w\\d\\-\\u0100-\\uffff.%]*)|'
I would prefer raw strings and not \\
Move the "|" into a separate line.

https://codereview.chromium.org/14753005/diff/5001/sdk/lib/uri/uri.dart#newco...
sdk/lib/uri/uri.dart:90: '\\[([A-Fa-f0-9:.]*)\\])'
Shouldn't you restrict the number of possible digits and ":" parts?

[Anders Johnsen, 2013-05-01 09:26:14]

Thanks, landing.

https://codereview.chromium.org/14753005/diff/5001/sdk/lib/uri/uri.dart
File sdk/lib/uri/uri.dart (right):

https://codereview.chromium.org/14753005/diff/5001/sdk/lib/uri/uri.dart#newco...
sdk/lib/uri/uri.dart:18: * '[' and ']' around the part.
On 2013/05/01 08:53:30, floitsch wrote:
> which part?

Done.

https://codereview.chromium.org/14753005/diff/5001/sdk/lib/uri/uri.dart#newco...
sdk/lib/uri/uri.dart:19: * [uri]:
http://closure-library.googlecode.com/svn/docs/class_goog_Uri.html
On 2013/05/01 08:53:30, floitsch wrote:
> URI ?

Done.

https://codereview.chromium.org/14753005/diff/5001/sdk/lib/uri/uri.dart#newco...
sdk/lib/uri/uri.dart:33: * Deprecated. Please use [parse] instead.
On 2013/05/01 08:53:30, floitsch wrote:
> Now that I see it: yes. Please get rid of it.

Done.

https://codereview.chromium.org/14753005/diff/5001/sdk/lib/uri/uri.dart#newco...
sdk/lib/uri/uri.dart:86: '([\\w\\d\\-\\u0100-\\uffff.%]*)|'
On 2013/05/01 08:53:30, floitsch wrote:
> I would prefer raw strings and not \\
> Move the "|" into a separate line.

Done.

https://codereview.chromium.org/14753005/diff/5001/sdk/lib/uri/uri.dart#newco...
sdk/lib/uri/uri.dart:90: '\\[([A-Fa-f0-9:.]*)\\])'
On 2013/05/01 08:53:30, floitsch wrote:
> Shouldn't you restrict the number of possible digits and ":" parts?

We don't really do validations like that atm, but I'll leave a TODO.

[Anders Johnsen, 2013-05-01 09:28:01]

Committed patchset #4 manually as r22228 (presubmit successful).