Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(530)

Issue 14752023: Fix the embedder on the desktop. (Closed)

Created:
7 years, 7 months ago by gram
Modified:
7 years, 7 months ago
Reviewers:
vsm
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Fix the embedder on the desktop. This is probably not enough for Android but Android build is failing due to some Skia issue (surprise!!) so I can't test it. R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=22579

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -7 lines) Patch
M runtime/embedders/openglui/common/vm_glue.cc View 2 chunks +38 lines, -7 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
gram
7 years, 7 months ago (2013-05-09 23:06:38 UTC) #1
vsm
lgtm
7 years, 7 months ago (2013-05-09 23:08:51 UTC) #2
gram
7 years, 7 months ago (2013-05-10 00:28:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22579 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698