Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14752008: Final step towards loading core library scripts directly from the sources (Closed)

Created:
7 years, 7 months ago by siva
Modified:
7 years, 7 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Final step towards loading core library scripts directly from the sources - Modify bin.gypi to ensure that the io library and patch files are read directly from the sources. Remove the source buffer generation step in the gypi files for all the io library and patch files. - Restructure the code a bit to eliminate some code duplication. - Delete runtime/tools/concat_library.py R=ager@google.com, sgjesse@google.com Committed: https://code.google.com/p/dart/source/detail?r=22514

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Total comments: 4

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+257 lines, -243 lines) Patch
M runtime/bin/bin.gypi View 1 2 3 4 5 6 11 chunks +28 lines, -35 lines 0 comments Download
M runtime/bin/builtin.h View 1 2 3 4 5 6 2 chunks +20 lines, -9 lines 0 comments Download
M runtime/bin/builtin.cc View 1 2 3 4 5 6 2 chunks +60 lines, -19 lines 0 comments Download
M runtime/bin/builtin_gen_snapshot.cc View 1 2 3 4 5 6 1 chunk +44 lines, -45 lines 0 comments Download
M runtime/bin/builtin_in.cc View 1 2 3 4 5 6 1 chunk +7 lines, -7 lines 0 comments Download
M runtime/bin/builtin_natives.cc View 1 2 3 4 5 6 3 chunks +18 lines, -18 lines 0 comments Download
M runtime/bin/builtin_nolib.cc View 1 2 3 4 5 6 2 chunks +9 lines, -18 lines 0 comments Download
M runtime/bin/dartutils.h View 1 2 3 4 5 6 3 chunks +3 lines, -6 lines 0 comments Download
M runtime/bin/dartutils.cc View 1 2 3 4 5 6 4 chunks +43 lines, -20 lines 0 comments Download
M runtime/bin/eventhandler_patch.dart View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
D runtime/bin/io.dart View 1 2 3 4 5 6 1 chunk +0 lines, -19 lines 0 comments Download
M runtime/bin/platform.cc View 1 2 3 4 5 6 1 chunk +4 lines, -1 line 0 comments Download
M runtime/bin/secure_socket.h View 1 2 3 4 5 6 1 chunk +3 lines, -2 lines 0 comments Download
D runtime/tools/concat_library.py View 1 2 3 4 5 6 1 chunk +0 lines, -43 lines 0 comments Download
M runtime/vm/unit_test.cc View 1 2 3 4 5 6 2 chunks +16 lines, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
siva
7 years, 7 months ago (2013-05-07 23:48:37 UTC) #1
siva
7 years, 7 months ago (2013-05-07 23:58:17 UTC) #2
Mads Ager (google)
LGTM! https://codereview.chromium.org/14752008/diff/30002/runtime/bin/bin.gypi File runtime/bin/bin.gypi (right): https://codereview.chromium.org/14752008/diff/30002/runtime/bin/bin.gypi#newcode66 runtime/bin/bin.gypi:66: '../../sdk/lib/io/io.dart', Thank you! :-) https://codereview.chromium.org/14752008/diff/30002/runtime/vm/unit_test.cc File runtime/vm/unit_test.cc (right): ...
7 years, 7 months ago (2013-05-08 06:20:49 UTC) #3
Søren Gjesse
LGTM
7 years, 7 months ago (2013-05-08 13:20:59 UTC) #4
siva
Thanks for the reviews. https://codereview.chromium.org/14752008/diff/30002/runtime/bin/bin.gypi File runtime/bin/bin.gypi (right): https://codereview.chromium.org/14752008/diff/30002/runtime/bin/bin.gypi#newcode66 runtime/bin/bin.gypi:66: '../../sdk/lib/io/io.dart', On 2013/05/08 06:20:49, Mads ...
7 years, 7 months ago (2013-05-08 16:38:17 UTC) #5
siva
7 years, 7 months ago (2013-05-08 16:42:54 UTC) #6
Message was sent while issue was closed. 
Committed patchset #7 manually as r22514 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698