Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Issue 14751012: Revert "Revert "Use clang on mac if XCode >= 4.5"" (Closed)

Created:
7 years, 7 months ago by kustermann
Modified:
7 years, 7 months ago
Reviewers:
ricow1, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Revert "Revert "Use clang on mac if XCode >= 4.5"" The V8 dependency has been removed, so we should be able to enable clang on mac again. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=22304

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -3 lines) Patch
M tools/gyp/find_mac_gcc_version.py View 1 chunk +6 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kustermann
7 years, 7 months ago (2013-05-02 08:26:20 UTC) #1
ricow1
LGTM
7 years, 7 months ago (2013-05-02 08:32:34 UTC) #2
kustermann
7 years, 7 months ago (2013-05-02 08:34:32 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22304 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698