Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 147453004: update web_components (Closed)

Created:
6 years, 10 months ago by Jennifer Messerly
Modified:
6 years, 10 months ago
Reviewers:
blois
CC:
reviews_dartlang.org
Visibility:
Public.

Description

update web_components removes note about custom_elements patch, it has been merged R=blois@google.com Committed: https://code.google.com/p/dart/source/detail?r=32589

Patch Set 1 #

Total comments: 7

Patch Set 2 : deletes polymer test script #

Unified diffs Side-by-side diffs Delta from patch set Stats (+654 lines, -571 lines) Patch
D pkg/polymer/test/run.sh View 1 1 chunk +0 lines, -30 lines 0 comments Download
M pkg/web_components/README.md View 1 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/web_components/lib/build.log View 1 2 chunks +6 lines, -6 lines 0 comments Download
M pkg/web_components/lib/platform.js View 1 1 chunk +5 lines, -5 lines 0 comments Download
M pkg/web_components/lib/platform.concat.js View 1 57 chunks +637 lines, -516 lines 0 comments Download
M pkg/web_components/lib/platform.concat.js.map View 1 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Jennifer Messerly
6 years, 10 months ago (2014-02-11 20:03:46 UTC) #1
Jennifer Messerly
ping :D
6 years, 10 months ago (2014-02-12 02:12:37 UTC) #2
blois
Some comments based on: http://google-styleguide.googlecode.com/svn/trunk/shell.xml https://codereview.chromium.org/147453004/diff/1/pkg/polymer/test/run.sh File pkg/polymer/test/run.sh (right): https://codereview.chromium.org/147453004/diff/1/pkg/polymer/test/run.sh#newcode12 pkg/polymer/test/run.sh:12: DIR=$( cd $( dirname ...
6 years, 10 months ago (2014-02-12 02:29:31 UTC) #3
Jennifer Messerly
i'll just revert the bash script changes :)
6 years, 10 months ago (2014-02-12 02:30:56 UTC) #4
Jennifer Messerly
rest of it looks good, I presume?
6 years, 10 months ago (2014-02-12 02:31:31 UTC) #5
Jennifer Messerly
fyi -- deleted bash script, saved my own copy
6 years, 10 months ago (2014-02-12 02:33:09 UTC) #6
blois
lgtm
6 years, 10 months ago (2014-02-12 02:36:22 UTC) #7
Jennifer Messerly
6 years, 10 months ago (2014-02-12 02:43:03 UTC) #8
Message was sent while issue was closed.
Committed patchset #2 manually as r32589 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698