Implementation of HTTP digest authentication

Implementation of HTTP digest authentication

This is the initial implementation. I am still missing the handling of
the server changing the nonce, but will do that in a separate CL.

Also this is currently not for proxy authentication.

R=ajohnsen@google.com
BUG=

Committed: https://code.google.com/p/dart/source/detail?r=22356

[Anders Johnsen, 2013-05-02 19:10:19]

LGTM, this is really solid! Nice! :D

https://codereview.chromium.org/14740015/diff/1/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/14740015/diff/1/sdk/lib/io/http.dart#newcode1287
sdk/lib/io/http.dart:1287: * algorithm and and quality of protection (qop) of
either "none" or
Double and.

https://codereview.chromium.org/14740015/diff/1/sdk/lib/io/http.dart#newcode1287
sdk/lib/io/http.dart:1287: * algorithm and and quality of protection (qop) of
either "none" or
QoP?

https://codereview.chromium.org/14740015/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/14740015/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:277: if (cr.scheme != _AuthenticationScheme.UNKNOWN) {
Merge ifs.

https://codereview.chromium.org/14740015/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:310: if (cr.scheme == _AuthenticationScheme.DIGEST &&
No used check? If missing, maybe move it to line 303.

https://codereview.chromium.org/14740015/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:311: (header.parameters["algorithm"] == null ||
!= String, or do we always know it's either null or String?

https://codereview.chromium.org/14740015/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1969: hasher.add(credentials.username.codeUnits);
Should we do any String encoding here, and below?

https://codereview.chromium.org/14740015/diff/1/tests/standalone/io/http_auth...
File tests/standalone/io/http_auth_digest_test.dart (right):

https://codereview.chromium.org/14740015/diff/1/tests/standalone/io/http_auth...
tests/standalone/io/http_auth_digest_test.dart:18: Future<Server> start(String
serverAlgorithm, String serverQop) {
Nit. This method could be made static.

[Søren Gjesse, 2013-05-03 08:10:36]

https://codereview.chromium.org/14740015/diff/1/sdk/lib/io/http.dart
File sdk/lib/io/http.dart (right):

https://codereview.chromium.org/14740015/diff/1/sdk/lib/io/http.dart#newcode1287
sdk/lib/io/http.dart:1287: * algorithm and and quality of protection (qop) of
either "none" or
On 2013/05/02 19:10:19, Anders Johnsen wrote:
> QoP?

rfc2617 uses all lowercase.

https://codereview.chromium.org/14740015/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/14740015/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:277: if (cr.scheme != _AuthenticationScheme.UNKNOWN) {
On 2013/05/02 19:10:19, Anders Johnsen wrote:
> Merge ifs.

Done.

https://codereview.chromium.org/14740015/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:310: if (cr.scheme == _AuthenticationScheme.DIGEST &&
On 2013/05/02 19:10:19, Anders Johnsen wrote:
> No used check? If missing, maybe move it to line 303.

The checking for whether the nonce is set works like the used check for basic
authentication. Updated comment and added TODO for handling changing nonce.

https://codereview.chromium.org/14740015/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:311: (header.parameters["algorithm"] == null ||
On 2013/05/02 19:10:19, Anders Johnsen wrote:
> != String, or do we always know it's either null or String?

Done.

https://codereview.chromium.org/14740015/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:311: (header.parameters["algorithm"] == null ||
On 2013/05/02 19:10:19, Anders Johnsen wrote:
> != String, or do we always know it's either null or String?

The HeaderValue only adds Strings to the map.

https://codereview.chromium.org/14740015/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:1969: hasher.add(credentials.username.codeUnits);
On 2013/05/02 19:10:19, Anders Johnsen wrote:
> Should we do any String encoding here, and below?

Added UTF-8 encoding and moved the coment from line 2082.

All the remaining strings should be fine.

https://codereview.chromium.org/14740015/diff/1/tests/standalone/io/http_auth...
File tests/standalone/io/http_auth_digest_test.dart (right):

https://codereview.chromium.org/14740015/diff/1/tests/standalone/io/http_auth...
tests/standalone/io/http_auth_digest_test.dart:18: Future<Server> start(String
serverAlgorithm, String serverQop) {
On 2013/05/02 19:10:19, Anders Johnsen wrote:
> Nit. This method could be made static.

Done.

[Søren Gjesse, 2013-05-03 08:58:47]

Committed patchset #3 manually as r22356 (presubmit successful).