Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 147353010: Infer types for compile-time constant closures. (Closed)

Created:
6 years, 10 months ago by floitsch
Modified:
6 years, 10 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org, ngeoffray
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Reupload #

Patch Set 3 : Add test. #

Patch Set 4 : More tests and status file update. #

Patch Set 5 : Fix bad types. #

Patch Set 6 : Fix typo. #

Patch Set 7 : Update status file and one more test. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -89 lines) Patch
M sdk/lib/_internal/compiler/implementation/inferrer/type_graph_inferrer.dart View 2 chunks +7 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/dart2js.status View 1 2 3 4 5 6 1 chunk +3 lines, -1 line 0 comments Download
A + tests/compiler/dart2js/simple_inferrer_const_closure2_test.dart View 2 chunks +8 lines, -20 lines 0 comments Download
A + tests/compiler/dart2js/simple_inferrer_const_closure3_test.dart View 1 2 3 4 1 chunk +18 lines, -16 lines 0 comments Download
A + tests/compiler/dart2js/simple_inferrer_const_closure4_test.dart View 1 2 3 4 1 chunk +20 lines, -16 lines 0 comments Download
A + tests/compiler/dart2js/simple_inferrer_const_closure5_test.dart View 1 2 3 4 5 1 chunk +19 lines, -16 lines 0 comments Download
A + tests/compiler/dart2js/simple_inferrer_global_field_closure2_test.dart View 1 2 3 4 5 6 1 chunk +18 lines, -16 lines 0 comments Download
A + tests/compiler/dart2js/simple_inferrer_global_field_closure_test.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
floitsch
Tests are not yet passing, because the closure-tracker doesn't track return types yet (and all ...
6 years, 10 months ago (2014-02-01 01:07:42 UTC) #1
sra1
On 2014/02/01 01:07:42, floitsch wrote: > Tests are not yet passing, because the closure-tracker doesn't ...
6 years, 10 months ago (2014-02-01 01:43:42 UTC) #2
floitsch
Done.
6 years, 10 months ago (2014-02-01 02:01:56 UTC) #3
floitsch
Tests are not yet working, but I will fix them before submitting.
6 years, 10 months ago (2014-02-03 14:24:12 UTC) #4
floitsch
Tests are updated.
6 years, 10 months ago (2014-02-03 18:53:41 UTC) #5
Johnni Winther
lgtm
6 years, 10 months ago (2014-02-04 06:47:56 UTC) #6
floitsch
Committed patchset #4 manually as r32276 (presubmit successful).
6 years, 10 months ago (2014-02-04 10:03:06 UTC) #7
floitsch
PTAL. I had to revert. Had to fix the types in the test. I'm now ...
6 years, 10 months ago (2014-02-04 10:43:57 UTC) #8
Johnni Winther
lgtm
6 years, 10 months ago (2014-02-04 11:56:41 UTC) #9
floitsch
6 years, 10 months ago (2014-02-04 12:40:24 UTC) #10
Message was sent while issue was closed.
Committed patchset #7 manually as r32279 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698