Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 147353005: Prevent accidental breakpoints in non-debuggable code (Closed)

Created:
6 years, 10 months ago by hausner
Modified:
6 years, 10 months ago
Reviewers:
regis
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Prevent accidental breakpoints in non-debuggable code Prevent setting accidental breakpoints in implicit getter and setter functions, and in initializer expressions that are inlined in field declarations. R=regis@google.com Committed: https://code.google.com/p/dart/source/detail?r=32183

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -14 lines) Patch
M runtime/vm/debugger.cc View 5 chunks +33 lines, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
hausner
So you don't get bored :)
6 years, 10 months ago (2014-01-30 23:18:13 UTC) #1
regis
On 2014/01/30 23:18:13, hausner wrote: > So you don't get bored :) Trying to set ...
6 years, 10 months ago (2014-01-30 23:30:28 UTC) #2
regis
LGTM
6 years, 10 months ago (2014-01-30 23:30:42 UTC) #3
hausner
6 years, 10 months ago (2014-01-30 23:38:38 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r32183 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698