Issue 14734004: Spys with mirrors!

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14734004: Spys with mirrors! (Closed)

Created:
7 years, 7 months ago by gram

Modified:
7 years, 7 months ago

Reviewers:
Siggi Cherem (dart-lang)

CC:
reviews_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Spys with mirrors! R=sigmund@google.com Committed: https://code.google.com/p/dart/source/detail?r=22371

Patch Set 3 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+53 lines, -2 lines)			Patch
	M	pkg/unittest/lib/mock.dart	View	1 2	5 chunks	+43 lines, -2 lines	0 comments	Download
	M	pkg/unittest/test/mock_test.dart	View	1 2	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Siggi Cherem (dart-lang)

lgtm https://codereview.chromium.org/14734004/diff/3001/pkg/unittest/lib/mock.dart File pkg/unittest/lib/mock.dart (right): https://codereview.chromium.org/14734004/diff/3001/pkg/unittest/lib/mock.dart#newcode1359 pkg/unittest/lib/mock.dart:1359: var rtn = mirror.delegate(invocation); nit: rtn => result, ...

7 years, 7 months ago (2013-05-02 01:01:26 UTC) #2

gram

7 years, 7 months ago (2013-05-03 15:43:17 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r22371 (presubmit successful).

Expand Messages | Collapse Messages

Issue 14734004: Spys with mirrors! (Closed)

Description

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Messages