Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 14727011: Adding library dependencies on windows (Closed)

Created:
7 years, 7 months ago by kustermann
Modified:
7 years, 7 months ago
Reviewers:
ricow1
CC:
reviews_dartlang.org, vm-dev_dartlang.org, Søren Gjesse, Mads Ager (google)
Visibility:
Public.

Description

Adding library dependencies on windows Previously gyp added a whole set of default library dependencies. These dependencies are no longer added by the gyp generator and have to explicitly state our dependencies in the gyp files. R=ricow@google.com Committed: https://code.google.com/p/dart/source/detail?r=22462

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M tools/gyp/configurations_msvs.gypi View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
kustermann
7 years, 7 months ago (2013-05-07 14:21:40 UTC) #1
ricow1
LGTM
7 years, 7 months ago (2013-05-07 14:25:41 UTC) #2
kustermann
7 years, 7 months ago (2013-05-07 14:26:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r22462 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698