Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 147213005: Use 'fail' instead of "MissingCompileTimeError" because of Dartium. (Closed)

Created:
6 years, 10 months ago by floitsch
Modified:
6 years, 10 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Use 'fail' instead of "MissingCompileTimeError" because of Dartium. Committed: https://code.google.com/p/dart/source/detail?r=32440

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tests/language/language.status View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
floitsch
TBR.
6 years, 10 months ago (2014-02-07 18:36:06 UTC) #1
floitsch
Committed patchset #1 manually as r32440 (presubmit successful).
6 years, 10 months ago (2014-02-07 18:36:22 UTC) #2
karlklose
6 years, 10 months ago (2014-02-10 11:54:12 UTC) #3
Message was sent while issue was closed.
On 2014/02/07 18:36:22, floitsch wrote:
> Committed patchset #1 manually as r32440 (presubmit successful).

LGTM.

Powered by Google App Engine
This is Rietveld 408576698