Issue 147153002: Re-enable mirrors/immutable_collections_test on Dartium. Fix a bad constructor in Dartium's dart:js…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 147153002: Re-enable mirrors/immutable_collections_test on Dartium. Fix a bad constructor in Dartium's dart:js… (Closed)

Created:
6 years, 11 months ago by rmacnak

Modified:
6 years, 11 months ago

Reviewers:
vsm, siva

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Re-enable mirrors/immutable_collections_test on Dartium. Fix a bad constructor in Dartium's dart:js. Mark as slow. BUG=http://dartbug.com/16027 R=vsm@google.com Committed: https://code.google.com/p/dart/source/detail?r=31996

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -2 lines)			Patch
	M	sdk/lib/js/dartium/js_dartium.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	tests/lib/lib.status	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

vsm

lgtm https://codereview.chromium.org/147153002/diff/1/tests/lib/mirrors/immutable_collections_test.dart File tests/lib/mirrors/immutable_collections_test.dart (right): https://codereview.chromium.org/147153002/diff/1/tests/lib/mirrors/immutable_collections_test.dart#newcode71 tests/lib/mirrors/immutable_collections_test.dart:71: print(lm.simpleName); Did you mean to keep this in?

6 years, 11 months ago (2014-01-24 20:37:12 UTC) #2

rmacnak

https://codereview.chromium.org/147153002/diff/1/tests/lib/mirrors/immutable_collections_test.dart File tests/lib/mirrors/immutable_collections_test.dart (right): https://codereview.chromium.org/147153002/diff/1/tests/lib/mirrors/immutable_collections_test.dart#newcode71 tests/lib/mirrors/immutable_collections_test.dart:71: print(lm.simpleName); On 2014/01/24 20:37:12, vsm wrote: > Did you ...

6 years, 11 months ago (2014-01-24 21:04:08 UTC) #3

rmacnak

6 years, 11 months ago (2014-01-24 21:05:03 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 manually as r31996 (presubmit successful).

Expand Messages | Collapse Messages