Issue 14711013: Implement backtracing and toggling of execution tracing in ARM simulator.

Issue 14711013: Implement backtracing and toggling of execution tracing in ARM simulator. (Closed)

Created:
7 years, 7 months ago by regis

Modified:
7 years, 7 months ago

Reviewers:
zra, Ivan Posva

CC:
reviews_dartlang.org, zra

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

More Reviews

Description

Implement backtracing and toggling of execution tracing in ARM simulator. R=zra@google.com Committed: https://code.google.com/p/dart/source/detail?r=22967

Patch Set 7 : #

Created: 7 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+140 lines, -15 lines)			Patch
M	runtime/vm/simulator_arm.cc	View	1 2 3 4 5 6	5 chunks	+88 lines, -0 lines	0 comments	Download
M	runtime/vm/stack_frame.h	View	1 2 3 4 5 6	5 chunks	+15 lines, -7 lines	0 comments	Download
M	runtime/vm/stack_frame.cc	View	1 2 3 4 5 6	6 chunks	+37 lines, -8 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

regis

I had to modify the stack trace iterator to start from any frame, rather than ...

7 years, 7 months ago (2013-05-15 23:48:14 UTC) #1

zra

lgtm https://codereview.chromium.org/14711013/diff/1/runtime/vm/stack_frame.cc File runtime/vm/stack_frame.cc (right): https://codereview.chromium.org/14711013/diff/1/runtime/vm/stack_frame.cc#newcode247 runtime/vm/stack_frame.cc:247: // iterator object current_frame_ will be NULL as ...

7 years, 7 months ago (2013-05-16 20:52:16 UTC) #2

regis

Thanks! https://codereview.chromium.org/14711013/diff/1/runtime/vm/stack_frame.cc File runtime/vm/stack_frame.cc (right): https://codereview.chromium.org/14711013/diff/1/runtime/vm/stack_frame.cc#newcode247 runtime/vm/stack_frame.cc:247: // iterator object current_frame_ will be NULL as ...

7 years, 7 months ago (2013-05-21 22:07:40 UTC) #3

regis

7 years, 7 months ago (2013-05-21 22:08:00 UTC) #4

Message was sent while issue was closed.

Committed patchset #7 manually as r22967 (presubmit successful).

Expand Messages | Collapse Messages