Fix file-watcher on mac by always starting/stopping through the run-loop thread.

Fix file-watcher on mac by always starting/stopping through the run-loop thread.

This also fixes some system error-printing and maybe also early events.

BUG=https://code.google.com/p/dart/issues/detail?id=16216
R=sgjesse@google.com

Committed: https://code.google.com/p/dart/source/detail?r=32355

[Søren Gjesse, 2014-02-06 13:04:18]

https://codereview.chromium.org/147083015/diff/1/runtime/bin/file_system_watc...
File runtime/bin/file_system_watcher_macos.cc (right):

https://codereview.chromium.org/147083015/diff/1/runtime/bin/file_system_watc...
runtime/bin/file_system_watcher_macos.cc:61: ready_(false),
Indent

https://codereview.chromium.org/147083015/diff/1/runtime/bin/file_system_watc...
runtime/bin/file_system_watcher_macos.cc:90: void Start() {
ASSERT(!ready_)

https://codereview.chromium.org/147083015/diff/1/runtime/bin/file_system_watc...
runtime/bin/file_system_watcher_macos.cc:115: void Stop() {
ASSERT(ready_)

https://codereview.chromium.org/147083015/diff/1/runtime/bin/file_system_watc...
runtime/bin/file_system_watcher_macos.cc:224: Node* node =
reinterpret_cast<Node*>(client);
Need to protect access to ready with the monitor.

[Anders Johnsen, 2014-02-06 13:15:22]

PTAL

https://codereview.chromium.org/147083015/diff/1/runtime/bin/file_system_watc...
File runtime/bin/file_system_watcher_macos.cc (right):

https://codereview.chromium.org/147083015/diff/1/runtime/bin/file_system_watc...
runtime/bin/file_system_watcher_macos.cc:61: ready_(false),
On 2014/02/06 13:04:19, Søren Gjesse wrote:
> Indent

Done.

https://codereview.chromium.org/147083015/diff/1/runtime/bin/file_system_watc...
runtime/bin/file_system_watcher_macos.cc:90: void Start() {
On 2014/02/06 13:04:19, Søren Gjesse wrote:
> ASSERT(!ready_)

Done.

https://codereview.chromium.org/147083015/diff/1/runtime/bin/file_system_watc...
runtime/bin/file_system_watcher_macos.cc:115: void Stop() {
On 2014/02/06 13:04:19, Søren Gjesse wrote:
> ASSERT(ready_)

Done.

https://codereview.chromium.org/147083015/diff/1/runtime/bin/file_system_watc...
runtime/bin/file_system_watcher_macos.cc:224: Node* node =
reinterpret_cast<Node*>(client);
On 2014/02/06 13:04:19, Søren Gjesse wrote:
> Need to protect access to ready with the monitor.

As discussed offline, is on same thread as run-loop.

[Søren Gjesse, 2014-02-06 13:16:00]

lgtm

[Anders Johnsen, 2014-02-06 13:16:20]

Committed patchset #2 manually as r32355 (presubmit successful).